Page MenuHomeFreeBSD

[llvm] Use 32 bit atomic on freebsd mips
ClosedPublic

Authored by adrian on Oct 13 2020, 10:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 12, 10:59 AM
Unknown Object (File)
Fri, Jul 11, 6:03 PM
Unknown Object (File)
Mon, Jul 7, 6:59 PM
Unknown Object (File)
Mon, Jul 7, 10:06 AM
Unknown Object (File)
Tue, Jul 1, 7:04 AM
Unknown Object (File)
Sun, Jun 29, 4:00 AM
Unknown Object (File)
Fri, Jun 27, 5:26 PM
Unknown Object (File)
Jun 25 2025, 9:23 AM
Subscribers

Details

Summary

gcc for mips32 doesn't include libatomic and doesn't generate
atomic sequences; so this just fails to link.

Instead, just use 32 bit for mips32/mips64.

(I haven't found a nice way to detect 32 or 64 bit mips here
without other header pollution, but it should be fine for freebsd/mips.)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is fine for now. Upstream will want to centralize the define somewhere in __config, but we can take that discussion there.

This revision is now accepted and ready to land.Oct 16 2020, 6:58 PM