Also PORTREVISION should not be changed if there are no functional changes, since you'd just be forcing rebuilds/updates of every dependent port for no reason.

In D25797#571704, @andrew_tao173.riddles.org.uk wrote:

5.3.6 is imminent, if there's any point at all in doing this cosmetic change then it could at least be folded into that.

In D25797#571705, @andrew_tao173.riddles.org.uk wrote:

Also PORTREVISION should not be changed if there are no functional changes, since you'd just be forcing rebuilds/updates of every dependent port for no reason.

I posted this now while I had the time because I'm prone to forget. We can let it sit until 5.3.6 is released. If I have time I'll update it with the RC1.

Here's one that updates to 5.3.6 and has more extensive changes to variable order that satisfies portclippy, barring the use of a few variables it doesn't know about.

kevans added a reviewer: kevans.Oct 15 2020, 1:09 PM

I'm going to commit this around noon my time (so ~3 hours from the time of writing, CDT/UTC-5) -- I'm going to go ahead and incorporate the pkg-plist change and PKGNAMESUFFIX=${LUA_VER_STR} change from the lua54 port. I'm also considering renaming patch-src__Makefile to patch-src_Makefile in advance so the provenance of the patch remains intact (for now) when lua53 gets repocopied over to lua54.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2020, 5:28 PM

Closed by commit rP552431: lang/lua53: update to 5.3.6 (authored by kevans). · Explain Why

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rP552431: lang/lua53: update to 5.3.6.