Page MenuHomeFreeBSD
Differential D26762

[libcasper] Use null inline functions when casper is disabled
ClosedPublic
Actions

Authored by adrian on Oct 13 2020, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 9, 5:51 PM
Unknown Object (File)
Sat, Jun 28, 10:12 AM
Unknown Object (File)
Tue, Jun 24, 1:38 AM
Unknown Object (File)
Jun 8 2025, 11:53 AM
Unknown Object (File)
Jun 7 2025, 12:00 PM
Unknown Object (File)
Jun 6 2025, 11:57 AM
Unknown Object (File)
Jun 4 2025, 6:58 AM
Unknown Object (File)
May 29 2025, 8:01 PM
View All 53 Files
Subscribers
imp

Details

Reviewers
emaste
oshogbo
kevans
Commits
rS366688: [libcasper] Update cap_dns API to not trigger unused variable warnings when…
Summary
  • use null functions rather than defines to make sure the compiler doesn't complain about unused function arguments, which gcc-6 on mips32 indeed does!
Test Plan
  • compiled for freebsd wifi mips testing where i actively disable this stuff to save space

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Oct 13 2020, 6:39 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 13 2020, 6:39 PM
adrian requested review of this revision.Oct 13 2020, 6:39 PM
Harbormaster completed remote builds in B34136: Diff 78177.Oct 13 2020, 6:39 PM
adrian added reviewers: emaste, oshogbo, kevans.Oct 13 2020, 6:42 PM
emaste added a comment.Oct 13 2020, 9:18 PM

Agree with the change, two small suggestions

lib/libcasper/services/cap_dns/cap_dns.h
47–48 ↗(On Diff #78177)

Maybe style disagrees but I'd probably just put these in the #else case below.

81 ↗(On Diff #78177)

maybe

static inline struct hostent *
cap_gethostbyname(cap_channel_t *chan __unused, const char *name)
This revision was not accepted when it landed; it landed in state Needs Review.Oct 13 2020, 10:50 PM
Closed by commit rS366688: [libcasper] Update cap_dns API to not trigger unused variable warnings when… (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rS366688: [libcasper] Update cap_dns API to not trigger unused variable warnings when….

Revision Contents
Changeset List

PathSize
head/
lib/
libcasper/
services/
cap_dns/
74 lines

Diff 78197

View Options

head/lib/libcasper/services/cap_dns/cap_dns.h

Loading...