[libcasper] Use null inline functions when casper is disabled
ClosedPublic
Actions

Authored by adrian on Oct 13 2020, 6:39 PM.

Details

Reviewers

emaste
oshogbo
kevans

Commits

rS366688: [libcasper] Update cap_dns API to not trigger unused variable warnings when…

Summary

use null functions rather than defines to make sure the compiler doesn't complain about unused function arguments, which gcc-6 on mips32 indeed does!

Test Plan

compiled for freebsd wifi mips testing where i actively disable this stuff to save space

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34136
Build 31296: arc lint + arc unit

Event Timeline

adrian created this revision.Oct 13 2020, 6:39 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2020, 6:39 PM

adrian requested review of this revision.Oct 13 2020, 6:39 PM

Harbormaster completed remote builds in B34136: Diff 78177.Oct 13 2020, 6:39 PM

adrian added reviewers: emaste, oshogbo, kevans.Oct 13 2020, 6:42 PM

Agree with the change, two small suggestions

lib/libcasper/services/cap_dns/cap_dns.h
47–48	Maybe style disagrees but I'd probably just put these in the `#else` case below.
81	maybe static inline struct hostent * cap_gethostbyname(cap_channel_t chan __unused, const char name)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 13 2020, 10:50 PM

Closed by commit rS366688: [libcasper] Update cap_dns API to not trigger unused variable warnings when… (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rS366688: [libcasper] Update cap_dns API to not trigger unused variable warnings when….

Revision Contents
Changeset List

Path

Size

lib/

libcasper/

services/

cap_dns/

cap_dns.h

85 lines

Diff 78177

View Options

lib/libcasper/services/cap_dns/cap_dns.h

[libcasper] Use null inline functions when casper is disabledClosedPublicActions