Update to 20.2
Move graphics/libxatracker to graphics/mesa-gallium-xa
Remove VAAPI and VDPAU options in mesa-libs in favor of
two new ports : mesa-gallium-va and mesa-gallium-vdpau
Bump needed llvm to llvm10
Change a lot of meson option from false to disabled as it's
deprecated.
Remove the drm and surfaceless platform from mesa* as it's always
enabled now.
Add zstd option, used for shader cache.
Details
Details
- Reviewers
zeising - Group Reviewers
x11 - Commits
- rP552109: graphics/mesa*: Update to 20.2
Tested on 13-CURRENT amd64 on intel and amd
Build tested on 11.4 (i386, amd64)
Build tested on 12.1 (i386, amd64)
Build tested on 13-CURRENT (amd64, armv7)
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 34024 Build 31211: arc lint + arc unit
Event Timeline
Comment Actions
A couple of things I found after looking briefly (and also from your WIP patch at some point). I'll do a more throughout check later in the week.
| MOVED | ||
|---|---|---|
| 15412 | Don't forget to update the date when committing. | |
| UPDATING | ||
| 8–15 | I wonder if this should be made into a pkg message in mesa-dri as well, that's showed on install. It will help people who use pkg to find these, since they are now available and possible to install. | |
| graphics/mesa-dri/Makefile.common | ||
| 19 | Whitespace? | |
| 101–102 | Perhaps we should ask the ppc64 people if it's ok to jump on the normal version. Not a showstopper. | |
| 102–105 | This logic might need to change? If I understand correctly, it the .elif checks if LLVM_DEFAULT is >= 90, and only then forcing LLVM_DEFAULT to 10. I think we should just hard code the supported version of LLVM (the version we want to support), without any regards for LLVM_DEFAULT. Otherwise, we probably want to make sure that people who set LLVM_DEFAULT to something lower than 10 get 10, because IIRC, older versions didn't work. | |
Comment Actions
Add missed patches earlier :
libatomic patches
clover patches
Address @zeising's comments.
Comment Actions
A few things, small nits.
What happened with the TLS (thread local storage) stuff? I know we talked about it, but I don't remember the result of the discussion. It looks like the patches to disable it has been removed locally. Are they added upstream or are we enabling TLS stuff now?
| UPDATING | ||
|---|---|---|
| 8–15 | I'd reword something like | |
| 12 | non-default or nondefault, options. | |
| 13 | named | |
| 14 | libs | |
| graphics/mesa-dri/Makefile | ||
| 11 | Does DRM and SURFACELESS always being on affect anything in the plist? | |
| graphics/mesa-dri/Makefile.common | ||
| 88 | This is not needed after the conversion to meson. It's just a left over from the conversion, probably worth it removing it at the same time. | |
| 109–112 | This will break popwerpc64 which still uses llvm90. | |
| graphics/mesa-dri/files/pkg-message.in | ||
| 1–9 | VAAPI, to be consistent with the UPDATING entry. I don't know if we need some explanation to when you might want to insall these? | |
| graphics/mesa-gallium-va/pkg-descr | ||
| 7 | is a Gallium driver | |
| graphics/mesa-gallium-vdpau/pkg-descr | ||
| 7 | Shouldn't it be "VDPAU is a Gallium driver"? | |
| lang/clover/Makefile | ||
| 39–41 | Why the second MESON_ARGS+= and not just continue on the one above? | |
Comment Actions
You also need to change the rename of xatracker in x11-drivers/xf86-video-vmware. Something like the attached should work.
Comment Actions
TLS is always disabled for us.
I'm not against enabling it for some version of FreeBSD but I need to test first (and on multiple arches too) so it's easier to leave it disabled for now.
See https://gitlab.freedesktop.org/mesa/mesa/-/blob/20.2/meson.build#L425
| graphics/mesa-dri/Makefile | ||
|---|---|---|
| 11 | Nope. | |