Page MenuHomeFreeBSD
Differential D26635

fusefs tests: quell Coverity "Argument cannot be negative" warnings
ClosedPublic
Actions

Authored by asomers on Oct 1 2020, 11:33 PM.
Tags
None
Referenced Files
F137021714: D26635.id77760.diff
Fri, Nov 21, 12:15 AM
F137020965: D26635.id77787.diff
Fri, Nov 21, 12:12 AM
F137020721: D26635.id.diff
Fri, Nov 21, 12:11 AM
F137019018: D26635.diff
Fri, Nov 21, 12:06 AM
Unknown Object (File)
Fri, Nov 14, 12:00 AM
Unknown Object (File)
Thu, Nov 13, 7:20 PM
Unknown Object (File)
Thu, Nov 13, 12:51 PM
Unknown Object (File)
Thu, Nov 13, 12:09 PM
View All 83 Files
Subscribers
cem
imp

Details

Reviewers
kevans
Commits
rS368596: MFC r366365:
rS366365: fusefs tests: quell Coverity "Argument cannot be negative" warnings
Summary

fusefs tests: quell Coverity "Argument cannot be negative" warnings

Must abort tests early if open(2) fails.

Coverity CID: 1432810 and many others

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33938
Build 31135: arc lint + arc unit

Event Timeline

asomers created this revision.Oct 1 2020, 11:33 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 1 2020, 11:33 PM
asomers requested review of this revision.Oct 1 2020, 11:33 PM
Harbormaster completed remote builds in B33938: Diff 77760.Oct 1 2020, 11:33 PM
cem resigned from this revision.Oct 1 2020, 11:47 PM

I don't care about non-material Coverity findings in test code.

asomers added a subscriber: cem.Oct 2 2020, 12:05 AM
In D26635#593310, @cem wrote:

I don't care about non-material Coverity findings in test code.

Then you don't care about quality. The only way to find real bugs with tools like this is to methodically squash all the warnings.

asomers edited reviewers, added: kevans; removed: cem.Oct 2 2020, 12:06 AM
cem added a comment.Oct 2 2020, 12:20 AM
In D26635#593312, @asomers wrote:

Then you don't care about quality. The only way to find real bugs with tools like this is to methodically squash all the warnings.

You're incorrect on both counts, and the attitude is totally unwarranted.

kevans accepted this revision.Oct 2 2020, 4:34 PM
This revision is now accepted and ready to land.Oct 2 2020, 4:34 PM
Closed by commit rS366365: fusefs tests: quell Coverity "Argument cannot be negative" warnings (authored by asomers). · Explain WhyOct 2 2020, 5:06 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS366365: fusefs tests: quell Coverity "Argument cannot be negative" warnings.
asomers added a commit: rS368596: MFC r366365:.Dec 12 2020, 10:57 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
fs/
fusefs/
2 lines
14 lines
4 lines
8 lines
4 lines
2 lines
12 lines
2 lines
62 lines

Diff 77760

View Options

tests/sys/fs/fusefs/allow_other.cc

Loading...
View Options

tests/sys/fs/fusefs/create.cc

Loading...
View Options

tests/sys/fs/fusefs/default_permissions.cc

Loading...
View Options

tests/sys/fs/fusefs/flush.cc

Loading...
View Options

tests/sys/fs/fusefs/open.cc

Loading...
View Options

tests/sys/fs/fusefs/opendir.cc

Loading...
View Options

tests/sys/fs/fusefs/release.cc

Loading...
View Options

tests/sys/fs/fusefs/releasedir.cc

Loading...
View Options

tests/sys/fs/fusefs/write.cc

Loading...