Page MenuHomeFreeBSD
Differential D26606

Don't ignore return value from gethostname(3)
ClosedPublic
Actions

Authored by trasz on Sep 30 2020, 11:33 AM.
Tags
None
Referenced Files
F137085821: D26606.id77749.diff
Fri, Nov 21, 2:57 AM
F137084614: D26606.id77677.diff
Fri, Nov 21, 2:55 AM
F137083986: D26606.id.diff
Fri, Nov 21, 2:53 AM
F137083091: D26606.diff
Fri, Nov 21, 2:51 AM
Unknown Object (File)
Sat, Nov 8, 2:41 AM
Unknown Object (File)
Thu, Nov 6, 12:37 AM
Unknown Object (File)
Sun, Oct 26, 6:39 AM
Unknown Object (File)
Oct 22 2025, 8:23 AM
View All 93 Files
Subscribers
imp
siderop1_netapp.com

Details

Reviewers
mav
Commits
rS366337: Don't ignore the return value from gethostname(3). It probably
Summary

Don't ignore return value from gethostname(3). It probably
cannot happen, but it silences down Coverity.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33899
Build 31101: arc lint + arc unit

Event Timeline

trasz created this revision.Sep 30 2020, 11:33 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 30 2020, 11:33 AM
trasz requested review of this revision.Sep 30 2020, 11:33 AM
Harbormaster completed remote builds in B33899: Diff 77677.Sep 30 2020, 11:33 AM
trasz edited the test plan for this revision. (Show Details)Sep 30 2020, 11:36 AM
trasz added a reviewer: mav.
trasz added a subscriber: siderop1_netapp.com.
mav accepted this revision.Sep 30 2020, 1:09 PM

I have feeling it is too aggressive to exit with error here, but since it should not really happen -- OK, will count it as an assertion. May be just assert then?

This revision is now accepted and ready to land.Sep 30 2020, 1:09 PM
trasz added a comment.Oct 1 2020, 3:41 PM

(Tinderboxed.)

trasz added a comment.Oct 1 2020, 3:42 PM
In D26606#592597, @mav wrote:

I have feeling it is too aggressive to exit with error here, but since it should not really happen -- OK, will count it as an assertion. May be just assert then?

Not sure how Coverity deals with asserts. Besides, I kind of like the current version.

Closed by commit rS366337: Don't ignore the return value from gethostname(3). It probably (authored by trasz). · Explain WhyOct 1 2020, 6:57 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS366337: Don't ignore the return value from gethostname(3). It probably.

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
24 lines

Diff 77677

View Options

usr.sbin/ctld/ctld.c

Loading...