Page MenuHomeFreeBSD

Don't ignore return value from gethostname(3)
ClosedPublic

Authored by trasz on Sep 30 2020, 11:33 AM.
Tags
None
Referenced Files
F139604231: D26606.id77749.diff
Sun, Dec 14, 1:18 AM
Unknown Object (File)
Tue, Dec 2, 5:28 PM
Unknown Object (File)
Sun, Nov 30, 12:25 PM
Unknown Object (File)
Tue, Nov 25, 11:17 AM
Unknown Object (File)
Fri, Nov 21, 2:57 AM
Unknown Object (File)
Fri, Nov 21, 2:55 AM
Unknown Object (File)
Fri, Nov 21, 2:53 AM
Unknown Object (File)
Fri, Nov 21, 2:51 AM

Details

Summary

Don't ignore return value from gethostname(3). It probably
cannot happen, but it silences down Coverity.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz added a reviewer: mav.
trasz added a subscriber: siderop1_netapp.com.

I have feeling it is too aggressive to exit with error here, but since it should not really happen -- OK, will count it as an assertion. May be just assert then?

This revision is now accepted and ready to land.Sep 30 2020, 1:09 PM
In D26606#592597, @mav wrote:

I have feeling it is too aggressive to exit with error here, but since it should not really happen -- OK, will count it as an assertion. May be just assert then?

Not sure how Coverity deals with asserts. Besides, I kind of like the current version.