Page MenuHomeFreeBSD

Don't ignore return value from gethostname(3)
ClosedPublic

Authored by trasz on Sep 30 2020, 11:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 5:20 PM
Unknown Object (File)
Thu, Sep 10, 12:49 PM
Unknown Object (File)
Mon, Sep 7, 8:58 AM
Unknown Object (File)
Sun, Sep 6, 7:50 PM
Unknown Object (File)
Sun, Sep 6, 9:38 AM
Unknown Object (File)
Sat, Sep 5, 2:20 PM
Unknown Object (File)
Fri, Sep 4, 11:38 PM
Unknown Object (File)
Fri, Sep 4, 9:26 AM

Details

Summary

Don't ignore return value from gethostname(3). It probably
cannot happen, but it silences down Coverity.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz added a reviewer: mav.
trasz added a subscriber: siderop1_netapp.com.

I have feeling it is too aggressive to exit with error here, but since it should not really happen -- OK, will count it as an assertion. May be just assert then?

This revision is now accepted and ready to land.Sep 30 2020, 1:09 PM
In D26606#592597, @mav wrote:

I have feeling it is too aggressive to exit with error here, but since it should not really happen -- OK, will count it as an assertion. May be just assert then?

Not sure how Coverity deals with asserts. Besides, I kind of like the current version.