libgssapi: modernize static string array use
ClosedPublic
Actions

Authored by brooks on Sep 29 2020, 8:21 PM.

Details

Reviewers

dfr
emaste
dim

Commits

rS366940: MFC r366671:
rS366912: MFC r366671:
rS366671: libgssapi: modernize static string array use

Summary

Use designated initializers to document positions in the arrays rather
than requiring counting. Use nitems() rather than rolling it by hand to
count elements.

Also, passify a Clang 12 warning about suspcious string concatenation
within an array initializer by adding parentheses.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33883
Build 31091: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Sep 29 2020, 8:21 PM

brooks created this revision.

Harbormaster completed remote builds in B33883: Diff 77647.Sep 29 2020, 8:21 PM

emaste accepted this revision.Sep 29 2020, 9:56 PM

emaste added inline comments.

lib/libgssapi/gss_display_status.c
134	If I were king of style(9) I would take an over-80-cols line vs relying on string concatenation; parens here make me stop and think for a second before accepting that the meaning is clear. Since I'm not the king of style, no objection.

This revision is now accepted and ready to land.Sep 29 2020, 9:56 PM

Closed by commit rS366671: libgssapi: modernize static string array use (authored by brooks). · Explain WhyOct 13 2020, 5:14 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS366671: libgssapi: modernize static string array use.

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2020, 5:14 PM

brooks added a commit: rS366912: MFC r366671:.Oct 21 2020, 4:05 PM

brooks added a commit: rS366940: MFC r366671:.Oct 22 2020, 4:41 PM