One more thing, can you update the version check in graphics/drm-kmod/Makefile as well?

In D26367#586341, @zeising wrote:

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

Well, installing the source will always causes problems when you update ports/package after building kernel but can help (sometimes) if nothing in base breaks building the module but it needs to be recompiled. It's the best solution that we have right now.

In D26367#586345, @zeising wrote:

One more thing, can you update the version check in graphics/drm-kmod/Makefile as well?

Good catch, I'll do that.

In D26367#586347, @manu wrote:

In D26367#586341, @zeising wrote:

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

Well, installing the source will always causes problems when you update ports/package after building kernel but can help (sometimes) if nothing in base breaks building the module but it needs to be recompiled. It's the best solution that we have right now.

We've had several support cases where there's been confusion as to which module was loaded because of this. But this discussion is bigger than this review, and not something that should prevent the update from happening. :)

In D26367#586352, @zeising wrote:

In D26367#586347, @manu wrote:

In D26367#586341, @zeising wrote:

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

Well, installing the source will always causes problems when you update ports/package after building kernel but can help (sometimes) if nothing in base breaks building the module but it needs to be recompiled. It's the best solution that we have right now.

We've had several support cases where there's been confusion as to which module was loaded because of this. But this discussion is bigger than this review, and not something that should prevent the update from happening. :)

Oh yeah there was and will be a lot more confusion, I personnaly don't like this situation but as you said, the discussion is bigger than this review :)