Page MenuHomeFreeBSD

graphics/drm-current-kmod: Update to drm_v5.4.62
ClosedPublic

Authored by manu on Wed, Sep 9, 9:15 AM.

Details

Summary

This update drm-current-kmod to be in sync with the latest Linux LTS
release.
aarch64 is also now supported for amdgpu and radeon.
vboxvideo is now added.

Sponsored-by: The FreeBSD Foundation
Signed-off-by: Emmanuel Vadot <manu@FreeBSD.org>

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu requested review of this revision.Wed, Sep 9, 9:15 AM
manu created this revision.
manu added a reviewer: emaste.Wed, Sep 9, 9:15 AM
manu set the repository for this revision to rS FreeBSD src repository.
zeising accepted this revision.Wed, Sep 9, 11:29 AM
zeising added a subscriber: zeising.

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

graphics/drm-current-kmod/pkg-plist
2 ↗(On Diff #76799)

If you remove this from the plist, you probably want to remove the PLIST_SUB+=AMDKFD in the Makefile as well.

This revision is now accepted and ready to land.Wed, Sep 9, 11:29 AM

One more thing, can you update the version check in graphics/drm-kmod/Makefile as well?

manu added a comment.Wed, Sep 9, 11:38 AM

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

Well, installing the source will always causes problems when you update ports/package after building kernel but can help (sometimes) if nothing in base breaks building the module but it needs to be recompiled. It's the best solution that we have right now.

graphics/drm-current-kmod/pkg-plist
2 ↗(On Diff #76799)

True, I'll update that.

manu added a comment.Wed, Sep 9, 11:42 AM

One more thing, can you update the version check in graphics/drm-kmod/Makefile as well?

Good catch, I'll do that.

In D26367#586347, @manu wrote:

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

Well, installing the source will always causes problems when you update ports/package after building kernel but can help (sometimes) if nothing in base breaks building the module but it needs to be recompiled. It's the best solution that we have right now.

We've had several support cases where there's been confusion as to which module was loaded because of this. But this discussion is bigger than this review, and not something that should prevent the update from happening. :)

manu added a comment.Wed, Sep 9, 11:56 AM
In D26367#586347, @manu wrote:

One small nit above, nothing important.

As a side note, I wonder if we really should keep the SOURCE option enabled, it has caused issues in the past when people first do a buildkernel (with the old sources) and then update ports and think they have the new stuff, while still loading the old module built with buildkernel.

Well, installing the source will always causes problems when you update ports/package after building kernel but can help (sometimes) if nothing in base breaks building the module but it needs to be recompiled. It's the best solution that we have right now.

We've had several support cases where there's been confusion as to which module was loaded because of this. But this discussion is bigger than this review, and not something that should prevent the update from happening. :)

Oh yeah there was and will be a lot more confusion, I personnaly don't like this situation but as you said, the discussion is bigger than this review :)

manu updated this revision to Diff 76806.Wed, Sep 9, 12:36 PM

Address @zeising's comments.

This revision now requires review to proceed.Wed, Sep 9, 12:36 PM
zeising accepted this revision.Wed, Sep 9, 12:55 PM
This revision is now accepted and ready to land.Wed, Sep 9, 12:55 PM
manu added inline comments.Wed, Sep 9, 2:12 PM
graphics/drm-kmod/Makefile
29 ↗(On Diff #76806)

I've missed this one, will fix when commiting.

zeising added inline comments.Wed, Sep 9, 5:31 PM
graphics/drm-kmod/Makefile
29 ↗(On Diff #76806)

Sounds good. I didn't see it either until you pointed it out. :)

This revision was automatically updated to reflect the committed changes.