Paths

Table of Contentst

Differential D26361

Don't return errors from the cryptodev_process() method.
ClosedPublic
Actions

Authored by jhb on Sep 8 2020, 4:51 PM.

Tags

None

Referenced Files

	F154264349: D26361.id76786.diff
	Mon, Apr 27, 11:45 AM

	Unknown Object (File)
	Sun, Apr 26, 6:56 AM

	Unknown Object (File)
	Sat, Apr 4, 12:35 PM

	Unknown Object (File)
	Sat, Apr 4, 2:00 AM

	Unknown Object (File)
	Thu, Apr 2, 5:01 AM

	Unknown Object (File)
	Mar 27 2026, 4:24 AM

	Unknown Object (File)
	Mar 19 2026, 9:33 PM

	Unknown Object (File)
	Jan 24 2026, 12:13 AM

View All 94 Files

Subscribers

Details

Reviewers

asomers
jmg

Commits

rS365478: Don't return errors from the cryptodev_process() method.

Summary

The cryptodev_process() method should either return 0 if it has
completed a request, or ERESTART to defer the request until later. If
a request encounters an error, the error should be reported via
crp_etype before completing the request via crypto_done().

Fix a few more drivers noticed by asomers@ similar to the fix in
r365389. This is an old bug, but went unnoticed since crypto requests
did not start failing as a normal part of operation until digest
verification was introduced which can fail requests with EBADMSG.

PR: 247986
Reported by: asomers

Test Plan

none yet, still need to compile test

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33444
Build 30728: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 8 2020, 4:51 PM

Herald added a subscriber: andrew. · View Herald TranscriptSep 8 2020, 4:51 PM

jhb requested review of this revision.Sep 8 2020, 4:51 PM

Harbormaster completed remote builds in B33444: Diff 76777.Sep 8 2020, 4:52 PM

jhb edited the summary of this revision. (Show Details)Sep 8 2020, 4:52 PM

jhb added inline comments.

sys/dev/safe/safe.c
1262	This is slightly different as we need to pass `ERESTART` to the caller.

asomers accepted this revision.Sep 8 2020, 5:44 PM

This revision is now accepted and ready to land.Sep 8 2020, 5:44 PM

Closed by commit rS365478: Don't return errors from the cryptodev_process() method. (authored by jhb). · Explain WhySep 8 2020, 10:41 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS365478: Don't return errors from the cryptodev_process() method..

Herald added a reviewer: jmg. · View Herald TranscriptSep 8 2020, 10:41 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

sys/

crypto/

armv8/

2 lines

dev/

hifn/

2 lines

safe/

1 line

Diff 76777

sys/crypto/armv8/armv8_crypto.c

Loading...

sys/dev/hifn/hifn7751.c

Loading...

sys/dev/safe/safe.c

Loading...