Page MenuHomeFreeBSD
Differential D26361

Don't return errors from the cryptodev_process() method.
ClosedPublic
Actions

Authored by jhb on Sep 8 2020, 4:51 PM.
Tags
None
Referenced Files
F132693306: D26361.id.diff
Sun, Oct 19, 2:44 AM
Unknown Object (File)
Sat, Oct 18, 8:43 PM
Unknown Object (File)
Sat, Oct 18, 7:42 PM
Unknown Object (File)
Sat, Oct 18, 6:27 PM
Unknown Object (File)
Thu, Oct 16, 3:18 PM
Unknown Object (File)
Thu, Oct 16, 3:18 PM
Unknown Object (File)
Thu, Oct 16, 3:18 PM
Unknown Object (File)
Thu, Oct 16, 3:54 AM
View All 79 Files
Subscribers
andrew
imp

Details

Reviewers
asomers
jmg
Commits
rS365478: Don't return errors from the cryptodev_process() method.
Summary

The cryptodev_process() method should either return 0 if it has
completed a request, or ERESTART to defer the request until later. If
a request encounters an error, the error should be reported via
crp_etype before completing the request via crypto_done().

Fix a few more drivers noticed by asomers@ similar to the fix in
r365389. This is an old bug, but went unnoticed since crypto requests
did not start failing as a normal part of operation until digest
verification was introduced which can fail requests with EBADMSG.

PR: 247986
Reported by: asomers

Test Plan
  • none yet, still need to compile test

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33444
Build 30728: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 8 2020, 4:51 PM
Herald added a subscriber: andrew. · View Herald TranscriptSep 8 2020, 4:51 PM
jhb requested review of this revision.Sep 8 2020, 4:51 PM
Harbormaster completed remote builds in B33444: Diff 76777.Sep 8 2020, 4:52 PM
jhb edited the summary of this revision. (Show Details)Sep 8 2020, 4:52 PM
jhb added inline comments.
sys/dev/safe/safe.c
1262

This is slightly different as we need to pass ERESTART to the caller.

asomers accepted this revision.Sep 8 2020, 5:44 PM
This revision is now accepted and ready to land.Sep 8 2020, 5:44 PM
Closed by commit rS365478: Don't return errors from the cryptodev_process() method. (authored by jhb). · Explain WhySep 8 2020, 10:41 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS365478: Don't return errors from the cryptodev_process() method..
Herald added a reviewer: jmg. · View Herald TranscriptSep 8 2020, 10:41 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
sys/
crypto/
armv8/
2 lines
dev/
hifn/
2 lines
safe/
1 line

Diff 76777

View Options

sys/crypto/armv8/armv8_crypto.c

Loading...
View Options

sys/dev/hifn/hifn7751.c

Loading...
View Options

sys/dev/safe/safe.c

Loading...