Page MenuHomeFreeBSD
Differential D26307

aw_clk_nm: fix incorrect use of abs()
ClosedPublic
Actions

Authored by avg on Sep 3 2020, 7:37 AM.
Tags
None
Referenced Files
F151245078: D26307.id76590.diff
Tue, Apr 7, 2:18 AM
F151182389: D26307.id76724.diff
Mon, Apr 6, 3:56 PM
Unknown Object (File)
Sat, Apr 4, 5:06 PM
Unknown Object (File)
Wed, Apr 1, 5:52 AM
Unknown Object (File)
Wed, Apr 1, 2:06 AM
Unknown Object (File)
Tue, Mar 31, 7:36 AM
Unknown Object (File)
Tue, Mar 31, 12:11 AM
Unknown Object (File)
Wed, Mar 25, 11:19 AM
View All Files
Subscribers
andrew
imp

Details

Reviewers
manu
mmel
Commits
rS365395: aw_clk_nm: fix incorrect use of abs()
Summary

abs() takes a (signed) int as input.
Instead, it was used with unsigned 64-bit integers.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg created this revision.Sep 3 2020, 7:37 AM
Herald added subscribers: andrew, imp. · View Herald TranscriptSep 3 2020, 7:37 AM
Harbormaster completed remote builds in B33352: Diff 76580.Sep 3 2020, 7:37 AM
avg requested review of this revision.Sep 3 2020, 7:37 AM
manu added a comment.Sep 3 2020, 9:28 AM

Thanks, I had no time to fix this.
abs is used on more clock drivers for allwinner so I think that adding the inline function to aw_clk.h would be better.

avg added a comment.Sep 3 2020, 10:01 AM

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

avg added a comment.Sep 3 2020, 10:07 AM

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

avg added a comment.Sep 3 2020, 10:08 AM

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

avg added a reviewer: mmel.Sep 3 2020, 10:10 AM
avg updated this revision to Diff 76590.Sep 3 2020, 10:16 AM

expose clk_freq_diff to other clk drivers

Harbormaster completed remote builds in B33357: Diff 76590.Sep 3 2020, 10:16 AM
manu accepted this revision.Sep 3 2020, 10:31 AM
This revision is now accepted and ready to land.Sep 3 2020, 10:31 AM
Closed by commit rS365395: aw_clk_nm: fix incorrect use of abs() (authored by avg). · Explain WhySep 7 2020, 6:27 AM
This revision was automatically updated to reflect the committed changes.
avg added a commit: rS365395: aw_clk_nm: fix incorrect use of abs().

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
allwinner/
clkng/
6 lines
dev/
extres/
clk/
6 lines

Diff 76724

View Options

head/sys/arm/allwinner/clkng/aw_clk_nm.c

Loading...
View Options

head/sys/dev/extres/clk/clk.h

Loading...