Page MenuHomeFreeBSD
Differential D26343

Improvements for src.conf(5) and build(7) man pages
ClosedPublic
Actions

Authored by gbe on Sep 6 2020, 7:43 AM.
Tags
None
Referenced Files
F134048774: D26343.diff
Thu, Oct 30, 8:01 AM
Unknown Object (File)
Tue, Oct 28, 9:07 PM
Unknown Object (File)
Sun, Oct 26, 9:34 AM
Unknown Object (File)
Sat, Oct 25, 3:47 PM
Unknown Object (File)
Sat, Oct 25, 12:31 PM
Unknown Object (File)
Thu, Oct 23, 5:27 PM
Unknown Object (File)
Sat, Oct 18, 5:25 PM
Unknown Object (File)
Sat, Oct 18, 12:21 PM
View All Files
Subscribers
bcr

Details

Reviewers
imp
jmg
Group Reviewers
manpages
Commits
rS366399: MFC r365640: Improvements for the src.conf(5) and build(7) man pages
rS365640: Improvements for the src.conf(5) and build(7) man pages
Summary

src.conf(5)

  • update the description

build(7)

  • update the headline
  • clarify how make(1) is executed
  • mention src.conf(5)

PR: 203863 (based on)

Test Plan

mandoc output review and 'mandoc -Tlint' checks

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33417
Build 30711: arc lint + arc unit

Event Timeline

gbe requested review of this revision.Sep 6 2020, 7:43 AM
gbe created this revision.
Harbormaster completed remote builds in B33417: Diff 76703.Sep 6 2020, 7:43 AM
gbe added a comment.Sep 7 2020, 5:17 PM

Could someone review this?

bcr accepted this revision as: manpages.Sep 7 2020, 5:25 PM
bcr added a subscriber: bcr.

Looks good to me from the man page side of things.

gbe added a comment.Sep 8 2020, 3:05 PM

@imp and @jmp could you take a look at this differential?

The original PR was generated after some mailing list discussions based on your feedback.

gbe added a comment.Sep 10 2020, 7:22 PM

@imp and @jmp what do you think about this differential? It is based on your mailing list feedback, even it was while ago!

imp added inline comments.Sep 10 2020, 10:13 PM
share/man/man7/build.7
600

lower case here.

tools/build/options/makeman
160

This gives me heartburn. src.conf applies to all src trees you might have in the system...

gbe updated this revision to Diff 76921.EditedSep 11 2020, 5:01 PM
  • PR 203863: Correct differential comments by @imp
Harbormaster completed remote builds in B33507: Diff 76921.Sep 11 2020, 5:01 PM
gbe marked 2 inline comments as done.Sep 11 2020, 5:03 PM
gbe added inline comments.
tools/build/options/makeman
160

I removed /usr/src.

imp accepted this revision.Sep 11 2020, 5:05 PM

I'm happy now. Thanks for listening to my feedback.

tools/build/options/makeman
160

perfect. thanks!

This revision is now accepted and ready to land.Sep 11 2020, 5:05 PM
Closed by commit rS365640: Improvements for the src.conf(5) and build(7) man pages (authored by gbe). · Explain WhySep 11 2020, 6:09 PM
This revision was automatically updated to reflect the committed changes.
gbe marked an inline comment as done.
gbe added a commit: rS365640: Improvements for the src.conf(5) and build(7) man pages.
gbe added a commit: rS366399: MFC r365640: Improvements for the src.conf(5) and build(7) man pages.Oct 3 2020, 2:45 PM

Revision Contents
Changeset List

PathSize
share/
man/
man5/
man7/
27 lines
tools/
build/
options/
5 lines

Diff 76703

View Options

share/man/man5/src.conf.5

Loading...
View Options

share/man/man7/build.7

Loading...
View Options

tools/build/options/makeman

Loading...