Make zpool on GELI work again.
ClosedPublic
Actions

Authored by delphij on Sep 4 2020, 11:11 PM.

Details

Reviewers

ngie
allanjude
mmacy

Commits

rS365348: Make zpool on GELI work again.

Summary

After OpenZFS import, zpool auto import behavior was moved to an explicit "zpool import -a", and the zpool rc.d script was added as a prerequisite of zvol.

However, in rS299839, zvol was added as a prerequisite of dumpon, making it to start very early and before all 'disks' providers. At this time, dumping on a zvol is not supported, so remove this requirement and make zpool depend on disks instead.

Test Plan

boot

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij requested review of this revision.Sep 4 2020, 11:11 PM

delphij created this revision.

Harbormaster completed remote builds in B33406: Diff 76677.Sep 4 2020, 11:11 PM

Remove dumpon support.

Harbormaster completed remote builds in B33407: Diff 76678.Sep 4 2020, 11:27 PM

delphij edited the summary of this revision. (Show Details)Sep 4 2020, 11:29 PM

delphij added reviewers: ngie, allanjude, mmacy.

allanjude accepted this revision.Sep 4 2020, 11:32 PM

This revision is now accepted and ready to land.Sep 4 2020, 11:32 PM

Closed by commit rS365348: Make zpool on GELI work again. (authored by delphij). · Explain WhySep 4 2020, 11:36 PM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rS365348: Make zpool on GELI work again..

Herald added a subscriber: imp. · View Herald TranscriptSep 4 2020, 11:36 PM

Macro stlgtm:

Revision Contents
Changeset List

Path

Size

head/

libexec/

rc/

rc.d/

zpool

2 lines

zvol

1 line

Diff 76679

View Options

head/libexec/rc/rc.d/zpool

	# $FreeBSD$			# $FreeBSD$

	PORTNAME= revive			PORTNAME= revive
	DISTVERSIONPREFIX= v			DISTVERSIONPREFIX= v
	DISTVERSION= 1.0.2			DISTVERSION= 1.0.2
	CATEGORIES= devel			CATEGORIES= devel

	MAINTAINER= vulcan@wired.sh			MAINTAINER= lcook@FreeBSD.org
	COMMENT= Extensible static code analysis framework for Go			COMMENT= Extensible static code analysis framework for Go

	LICENSE= MIT			LICENSE= MIT
	LICENSE_FILE= ${WRKSRC}/LICENSE			LICENSE_FILE= ${WRKSRC}/LICENSE

	USES= go:modules			USES= go:modules
	USE_GITHUB= yes			USE_GITHUB= yes
	GH_ACCOUNT= mgechev			GH_ACCOUNT= mgechev
	Show All 32 Lines