Page MenuHomeFreeBSD
Differential D26319

RISC-V: fix some mismatched format specifiers
ClosedPublic
Actions

Authored by mhorne on Sep 4 2020, 12:24 AM.
Tags
None
Referenced Files
F151808959: D26319.id76764.diff
Fri, Apr 10, 7:57 PM
F151805083: D26319.diff
Fri, Apr 10, 7:20 PM
F151787804: D26319.id.diff
Fri, Apr 10, 4:32 PM
Unknown Object (File)
Thu, Apr 9, 11:45 PM
Unknown Object (File)
Thu, Apr 9, 9:35 PM
Unknown Object (File)
Tue, Apr 7, 3:18 PM
Unknown Object (File)
Tue, Apr 7, 8:46 AM
Unknown Object (File)
Tue, Apr 7, 8:43 AM
View All Files
Subscribers
arichardson
imp

Details

Reviewers
jhb
br
Group Reviewers
riscv
Commits
rS365455: RISC-V: fix some mismatched format specifiers
Summary

RISC-V has been built with -Wno-format, which is how these went undetected.
Address them now before re-enabling those warnings.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33374
Build 30678: arc lint + arc unit

Event Timeline

mhorne requested review of this revision.Sep 4 2020, 12:24 AM
mhorne created this revision.
Harbormaster completed remote builds in B33374: Diff 76631.Sep 4 2020, 12:24 AM
arichardson added a subscriber: arichardson.Sep 4 2020, 7:24 AM
arichardson added inline comments.
sys/riscv/riscv/db_disasm.c
419

Could also use %x since it's an int? How is this not triggering warnings with clang?

527

Same here?

mhorne added inline comments.Sep 4 2020, 1:44 PM
sys/riscv/riscv/db_disasm.c
419

Yeah, that is better.

Looks like -Wno-format is passed when MK_FORMAT_EXTENSIONS == "no", so that would be why clang hasn't complained. I'm enabling it in D26320.

mhorne updated this revision to Diff 76650.Sep 4 2020, 1:57 PM

Address @arichardson's comment. Fix one additional instance in a riscv-specific driver.

Harbormaster completed remote builds in B33390: Diff 76650.Sep 4 2020, 1:57 PM
mhorne edited the summary of this revision. (Show Details)Sep 4 2020, 2:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2020, 1:21 PM
Closed by commit rS365455: RISC-V: fix some mismatched format specifiers (authored by mhorne). · Explain Why
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rS365455: RISC-V: fix some mismatched format specifiers.
Herald added a subscriber: imp. · View Herald TranscriptSep 8 2020, 1:21 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
4 lines
8 lines
2 lines
4 lines
4 lines

Diff 76631

View Options

sys/riscv/riscv/db_disasm.c

Loading...
View Options

sys/riscv/riscv/intr_machdep.c

Loading...
View Options

sys/riscv/riscv/pmap.c

Loading...
View Options

sys/riscv/riscv/sbi.c

Loading...
View Options

sys/riscv/riscv/trap.c

Loading...