aw_clk_nm: fix incorrect use of abs()
ClosedPublic
Actions

Authored by avg on Sep 3 2020, 7:37 AM.

Details

Reviewers

manu
mmel

Commits

rS365395: aw_clk_nm: fix incorrect use of abs()

Summary

abs() takes a (signed) int as input.
Instead, it was used with unsigned 64-bit integers.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33352
Build 30661: arc lint + arc unit

Event Timeline

avg created this revision.Sep 3 2020, 7:37 AM

Herald added subscribers: andrew, imp. · View Herald TranscriptSep 3 2020, 7:37 AM

Harbormaster completed remote builds in B33352: Diff 76580.Sep 3 2020, 7:37 AM

avg requested review of this revision.Sep 3 2020, 7:37 AM

Thanks, I had no time to fix this.
abs is used on more clock drivers for allwinner so I think that adding the inline function to aw_clk.h would be better.

If this function to become more visible, do you think distance is still a good name?
Maybe something like freq_diff? Something else?
Thanks!

avg added a reviewer: mmel.Sep 3 2020, 10:10 AM

expose clk_freq_diff to other clk drivers

Harbormaster completed remote builds in B33357: Diff 76590.Sep 3 2020, 10:16 AM

manu accepted this revision.Sep 3 2020, 10:31 AM

This revision is now accepted and ready to land.Sep 3 2020, 10:31 AM

Closed by commit rS365395: aw_clk_nm: fix incorrect use of abs() (authored by avg). · Explain WhySep 7 2020, 6:27 AM

This revision was automatically updated to reflect the committed changes.

avg added a commit: rS365395: aw_clk_nm: fix incorrect use of abs().

Revision Contents
Changeset List

Path

Size

sys/

arm/

allwinner/

clkng/

aw_clk_nm.c

10 lines

Diff 76580

View Options

sys/arm/allwinner/clkng/aw_clk_nm.c

aw_clk_nm: fix incorrect use of abs()ClosedPublicActions