Page MenuHomeFreeBSD
Differential D26197

Fix a buffer overrun.
ClosedPublic
Actions

Authored by jhb on Aug 26 2020, 4:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 2, 1:48 PM
Unknown Object (File)
Wed, Sep 30, 6:50 PM
Unknown Object (File)
Wed, Sep 30, 6:42 PM
Unknown Object (File)
Wed, Sep 30, 3:39 PM
Unknown Object (File)
Tue, Sep 29, 2:51 AM
Unknown Object (File)
Thu, Sep 10, 9:10 PM
Unknown Object (File)
Sun, Sep 6, 4:13 PM
Unknown Object (File)
Sun, Sep 6, 3:32 PM
View All Files
Subscribers
imp

Details

Reviewers
brooks
Commits
rS365055: Fix a buffer overrun.
Summary

fgetln() returns 'len' valid characters. line[len] is out of bounds.

Reported by: CHERI
Obtained from: CheriBSD

Test Plan
  • tests failed when compiled under CHERI and pass afterwards

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Aug 26 2020, 4:40 PM
jhb created this revision.
Harbormaster completed remote builds in B33173: Diff 76251.Aug 26 2020, 4:40 PM
brooks accepted this revision.Aug 26 2020, 5:54 PM
This revision is now accepted and ready to land.Aug 26 2020, 5:54 PM
Closed by commit rS365055: Fix a buffer overrun. (authored by jhb). · Explain WhySep 1 2020, 4:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS365055: Fix a buffer overrun..
Herald added a subscriber: imp. · View Herald TranscriptSep 1 2020, 4:20 PM

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
tests/
resolv/
6 lines

Diff 76496

View Options

head/lib/libc/tests/resolv/resolv_test.c

Loading...