Fix a buffer overrun.
ClosedPublic
Actions

Authored by jhb on Aug 26 2020, 4:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 28, 11:41 AM

	Unknown Object (File)
	Dec 20 2023, 6:10 AM

	Unknown Object (File)
	Dec 14 2023, 3:53 PM

	Unknown Object (File)
	Jul 9 2023, 8:09 PM

	Unknown Object (File)
	Jul 4 2023, 7:44 AM

	Unknown Object (File)
	Jul 4 2023, 7:42 AM

	Unknown Object (File)
	Jul 4 2023, 7:39 AM

	Unknown Object (File)
	Jul 4 2023, 7:31 AM

View All 12 Files

Subscribers

imp

Details

Reviewers

brooks

Commits

rS365055: Fix a buffer overrun.

Summary

fgetln() returns 'len' valid characters. line[len] is out of bounds.

Reported by: CHERI
Obtained from: CheriBSD

Test Plan

tests failed when compiled under CHERI and pass afterwards

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 33173
Build 30522: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Aug 26 2020, 4:40 PM

jhb created this revision.

Harbormaster completed remote builds in B33173: Diff 76251.Aug 26 2020, 4:40 PM

brooks accepted this revision.Aug 26 2020, 5:54 PM

This revision is now accepted and ready to land.Aug 26 2020, 5:54 PM

Closed by commit rS365055: Fix a buffer overrun. (authored by jhb). · Explain WhySep 1 2020, 4:20 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS365055: Fix a buffer overrun..

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2020, 4:20 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

tests/

resolv/

resolv_test.c

6 lines

Diff 76251

View Options

lib/libc/tests/resolv/resolv_test.c

Fix a buffer overrun.ClosedPublicActions