Page MenuHomeFreeBSD
Differential D26197

Fix a buffer overrun.
ClosedPublic
Actions

Authored by jhb on Aug 26 2020, 4:40 PM.
Tags
None
Referenced Files
F108635626: D26197.id76251.diff
Mon, Jan 27, 12:37 AM
F108537758: D26197.id76496.diff
Sun, Jan 26, 1:46 AM
Unknown Object (File)
Tue, Jan 21, 5:59 AM
Unknown Object (File)
Nov 25 2024, 1:49 PM
Unknown Object (File)
Nov 23 2024, 12:34 PM
Unknown Object (File)
Nov 20 2024, 5:41 PM
Unknown Object (File)
Nov 19 2024, 3:16 PM
Unknown Object (File)
Nov 19 2024, 10:47 AM
View All 62 Files
Subscribers
imp

Details

Reviewers
brooks
Commits
rS365055: Fix a buffer overrun.
Summary

fgetln() returns 'len' valid characters. line[len] is out of bounds.

Reported by: CHERI
Obtained from: CheriBSD

Test Plan
  • tests failed when compiled under CHERI and pass afterwards

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Aug 26 2020, 4:40 PM
jhb created this revision.
Harbormaster completed remote builds in B33173: Diff 76251.Aug 26 2020, 4:40 PM
brooks accepted this revision.Aug 26 2020, 5:54 PM
This revision is now accepted and ready to land.Aug 26 2020, 5:54 PM
Closed by commit rS365055: Fix a buffer overrun. (authored by jhb). · Explain WhySep 1 2020, 4:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS365055: Fix a buffer overrun..
Herald added a subscriber: imp. · View Herald TranscriptSep 1 2020, 4:20 PM

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
tests/
resolv/
6 lines

Diff 76496

View Options

head/lib/libc/tests/resolv/resolv_test.c

Loading...