Page MenuHomeFreeBSD
Differential D26197

Fix a buffer overrun.
ClosedPublic
Actions

Authored by jhb on Aug 26 2020, 4:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 26, 11:44 AM
Unknown Object (File)
Tue, Aug 25, 11:40 PM
Unknown Object (File)
Tue, Aug 25, 9:09 PM
Unknown Object (File)
Sun, Aug 23, 8:55 PM
Unknown Object (File)
Sun, Aug 23, 4:32 PM
Unknown Object (File)
Sun, Aug 23, 12:21 PM
Unknown Object (File)
Sat, Aug 22, 11:30 AM
Unknown Object (File)
Wed, Aug 12, 4:06 PM
View All Files
Subscribers
imp

Details

Reviewers
brooks
Commits
rS365055: Fix a buffer overrun.
Summary

fgetln() returns 'len' valid characters. line[len] is out of bounds.

Reported by: CHERI
Obtained from: CheriBSD

Test Plan
  • tests failed when compiled under CHERI and pass afterwards

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 33173
Build 30522: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Aug 26 2020, 4:40 PM
jhb created this revision.
Harbormaster completed remote builds in B33173: Diff 76251.Aug 26 2020, 4:40 PM
brooks accepted this revision.Aug 26 2020, 5:54 PM
This revision is now accepted and ready to land.Aug 26 2020, 5:54 PM
Closed by commit rS365055: Fix a buffer overrun. (authored by jhb). · Explain WhySep 1 2020, 4:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS365055: Fix a buffer overrun..
Herald added a subscriber: imp. · View Herald TranscriptSep 1 2020, 4:20 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
tests/
resolv/
6 lines

Diff 76251

View Options

lib/libc/tests/resolv/resolv_test.c

Loading...