Rename rt_flags to rte_flags && reduce number of rt_nhop accesses.
ClosedPublic
Actions

Authored by melifaro on Aug 21 2020, 11:06 PM.

Details

Reviewers

None

Group Reviewers

network

Commits

rS364492: Rename rt_flags to rte_flags && reduce number of rt_nhop accesses.

Summary

No functional changes.

Most of the routing flags are stored in the netxtop instead of rtentry.
Rename rt->rt_flags to rt->rte_flags to simplify reading/modifying code checking routing flags.

In the new multipath code, rt->rt_nhop may actually point to nexthop group instead of nhop.
To ease transition, reduce the amount of rt_nhop->... accesses.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33102
Build 30473: arc lint + arc unit

Event Timeline

melifaro created this revision.Aug 21 2020, 11:06 PM

Herald added subscribers: ae, imp. · View Herald TranscriptAug 21 2020, 11:06 PM

melifaro requested review of this revision.Aug 21 2020, 11:06 PM

Harbormaster completed remote builds in B33102: Diff 76081.Aug 21 2020, 11:06 PM

melifaro retitled this revision from Rename rt_flags to rte_flags && reduce number of rt_nhop accesses. Most of the routing flags are stored in the netxtop instead of rtentry. Rename `rt->rt_flags` to `rt->rte_flags` to simplify reading of flags checking code. In the new... to Rename rt_flags to rte_flags && reduce number of rt_nhop accesses..Aug 21 2020, 11:08 PM

melifaro edited the summary of this revision. (Show Details)

melifaro added a reviewer: network.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2020, 7:31 PM

Closed by commit rS364492: Rename rt_flags to rte_flags && reduce number of rt_nhop accesses. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS364492: Rename rt_flags to rte_flags && reduce number of rt_nhop accesses..