Page MenuHomeFreeBSD

uma: Check the full bucket cache before short-circuiting.
ClosedPublic

Authored by markj on Aug 6 2020, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 25, 8:58 PM
Unknown Object (File)
Nov 20 2025, 1:49 AM
Unknown Object (File)
Nov 17 2025, 10:02 PM
Unknown Object (File)
Nov 12 2025, 11:55 PM
Unknown Object (File)
Nov 3 2025, 11:43 AM
Unknown Object (File)
Oct 29 2025, 5:31 AM
Unknown Object (File)
Oct 28 2025, 12:54 PM
Unknown Object (File)
Oct 28 2025, 10:33 AM
Subscribers

Details

Summary

The global bucketdisable flag indicates that we are in a low-memory
situation and should avoid allocating buckets. However, in the
allocation path we were checking it before the full bucket cache. Defer
the check so that we have a shot at allocating from the cache.

This came up because allocations from buf_trie_zone must always succeed.
In one scenario, all of the preallocated trie nodes were in the bucket
list, and a new slab allocation could not succeed due to a memory
shortage. The short-circuiting caused an allocation failure which
triggered a panic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable