Fix memory leak in sddaregister().
ClosedPublic
Actions

Authored by bz on Aug 7 2020, 11:50 AM.

Tags

None

Referenced Files

	F169394410: D25987.id.diff
	Tue, Sep 1, 10:09 AM

	F169392492: D25987.id.diff
	Tue, Sep 1, 9:59 AM

	F169309598: D25987.id75552.diff
	Tue, Sep 1, 4:23 AM

	Unknown Object (File)
	Tue, Sep 1, 2:38 AM

	Unknown Object (File)
	Tue, Sep 1, 1:12 AM

	Unknown Object (File)
	Mon, Aug 31, 7:12 PM

	Unknown Object (File)
	Sun, Aug 30, 12:14 PM

	Unknown Object (File)
	Sun, Aug 30, 9:52 AM

View All Files

Subscribers

None

Details

Reviewers

kibab
manu
imp
scottl

Group Reviewers

cam

Commits

rS364043: mmc_da: fix memory leak in sddaregister()

Summary

In case we are failing to allocate mmcdata, we are returning with
a softc allocated but not attached to anything and thus leak the
memory.

MFC after: 2 weeks
X-MFC: only if we also mfc other mmccam changes?

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Aug 7 2020, 11:50 AM

Herald added a reviewer: cam. · View Herald TranscriptAug 7 2020, 11:50 AM

bz requested review of this revision.Aug 7 2020, 11:50 AM

Harbormaster completed remote builds in B32834: Diff 75552.Aug 7 2020, 11:50 AM

scottl accepted this revision.Aug 7 2020, 6:38 PM

This revision is now accepted and ready to land.Aug 7 2020, 6:38 PM

Closed by commit rS364043: mmc_da: fix memory leak in sddaregister() (authored by bz). · Explain WhyAug 7 2020, 7:58 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rS364043: mmc_da: fix memory leak in sddaregister().

Revision Contents
Changeset List

Path

Size

head/

sys/

cam/

mmc/

mmc_da.c

2 lines

Diff 75590

View Options

Fix memory leak in sddaregister().ClosedPublicActions