Page MenuHomeFreeBSD

uma: Check the full bucket cache before short-circuiting.
ClosedPublic

Authored by markj on Aug 6 2020, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 19, 6:27 AM
Unknown Object (File)
Mon, Aug 17, 11:05 AM
Unknown Object (File)
Sun, Aug 9, 8:12 PM
Unknown Object (File)
Sun, Aug 9, 3:48 PM
Unknown Object (File)
Sun, Aug 9, 3:47 PM
Unknown Object (File)
Mon, Jul 27, 4:53 PM
Unknown Object (File)
May 30 2026, 10:28 PM
Unknown Object (File)
May 28 2026, 8:30 PM
Subscribers

Details

Summary

The global bucketdisable flag indicates that we are in a low-memory
situation and should avoid allocating buckets. However, in the
allocation path we were checking it before the full bucket cache. Defer
the check so that we have a shot at allocating from the cache.

This came up because allocations from buf_trie_zone must always succeed.
In one scenario, all of the preallocated trie nodes were in the bucket
list, and a new slab allocation could not succeed due to a memory
shortage. The short-circuiting caused an allocation failure which
triggered a panic.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32821
Build 30236: arc lint + arc unit