Page MenuHomeFreeBSD

uma: Check the full bucket cache before short-circuiting.
ClosedPublic

Authored by markj on Aug 6 2020, 7:01 PM.
Tags
None
Referenced Files
F136461805: D25980.diff
Mon, Nov 17, 10:02 PM
Unknown Object (File)
Wed, Nov 12, 11:55 PM
Unknown Object (File)
Mon, Nov 3, 11:43 AM
Unknown Object (File)
Wed, Oct 29, 5:31 AM
Unknown Object (File)
Tue, Oct 28, 12:54 PM
Unknown Object (File)
Tue, Oct 28, 10:33 AM
Unknown Object (File)
Sat, Oct 25, 2:53 PM
Unknown Object (File)
Thu, Oct 23, 1:33 AM
Subscribers

Details

Summary

The global bucketdisable flag indicates that we are in a low-memory
situation and should avoid allocating buckets. However, in the
allocation path we were checking it before the full bucket cache. Defer
the check so that we have a shot at allocating from the cache.

This came up because allocations from buf_trie_zone must always succeed.
In one scenario, all of the preallocated trie nodes were in the bucket
list, and a new slab allocation could not succeed due to a memory
shortage. The short-circuiting caused an allocation failure which
triggered a panic.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32821
Build 30236: arc lint + arc unit