ctfmerge: Fix missing pthread_cond_init()
ClosedPublic
Actions

Authored by arichardson on Aug 6 2020, 11:21 AM.

Tags

None

Referenced Files

	F156860200: D25973.id75484.diff
	Sat, May 16, 11:04 PM

	F156860184: D25973.id75525.diff
	Sat, May 16, 11:03 PM

	F156859400: D25973.diff
	Sat, May 16, 10:59 PM

	Unknown Object (File)
	Mon, May 11, 7:27 AM

	Unknown Object (File)
	Mon, May 11, 7:17 AM

	Unknown Object (File)
	Sat, May 9, 6:18 PM

	Unknown Object (File)
	Sat, May 9, 6:12 PM

	Unknown Object (File)
	Fri, May 8, 7:36 PM

View All Files

Subscribers

imp

Details

Reviewers

brooks
markj
bdrewery

Commits

rS363991: ctfmerge: Fix missing pthread_cond_init()

Summary

This does not appear to matter on FreeBSD or Linux, but when building an
amd64 kernel on macOS I was seeing infinite loops in ctfmerge.
It turns out the loop in wip_save_work() was looping forever due to
pthread_cond_wait() always returning -EINVAL.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 32802
Build 30224: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Aug 6 2020, 11:21 AM

arichardson created this revision.

Harbormaster completed remote builds in B32802: Diff 75484.Aug 6 2020, 11:21 AM

markj accepted this revision.Aug 6 2020, 2:01 PM

This revision is now accepted and ready to land.Aug 6 2020, 2:01 PM

brooks accepted this revision.Aug 6 2020, 7:27 PM

Closed by commit rS363991: ctfmerge: Fix missing pthread_cond_init() (authored by arichardson). · Explain WhyAug 6 2020, 8:45 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS363991: ctfmerge: Fix missing pthread_cond_init().

Herald added a subscriber: imp. · View Herald TranscriptAug 6 2020, 8:45 PM

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

tools/

ctf/

cvt/

ctfmerge.c

1 line

Diff 75484

View Options

cddl/contrib/opensolaris/tools/ctf/cvt/ctfmerge.c

ctfmerge: Fix missing pthread_cond_init()ClosedPublicActions