Page MenuHomeFreeBSD
Differential D25957

Add machine/iommu.h
ClosedPublic
Actions

Authored by br on Aug 5 2020, 1:19 PM.
Tags
None
Referenced Files
F147359324: D25957.id75424.diff
Tue, Mar 10, 7:42 AM
F147333104: D25957.id75424.diff
Tue, Mar 10, 1:56 AM
Unknown Object (File)
Fri, Mar 6, 7:47 AM
Unknown Object (File)
Mon, Mar 2, 10:20 AM
Unknown Object (File)
Sun, Mar 1, 6:12 AM
Unknown Object (File)
Feb 8 2026, 10:08 AM
Unknown Object (File)
Feb 8 2026, 7:06 AM
Unknown Object (File)
Feb 7 2026, 7:26 PM
View All Files
Subscribers
imp
rpokala

Details

Reviewers
kib
andrew
Commits
rS363929: o Add machine/iommu.h and include MD iommu headers from it,
Summary

o Move headers inclusion to machine/iommu.h, to eliminate ifdefs (Suggested by: andrew)
o No need to include specialreg.h

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Aug 5 2020, 1:19 PM
br created this revision.
kib added a comment.EditedAug 5 2020, 3:01 PM

I suggest to preemptively add include protection even despite the fact that current x86 iommu.h does not need it ATM.

And you need i386/include/iommu.h.

br updated this revision to Diff 75431.Aug 5 2020, 3:36 PM

o Header protection added
o i386/include/iommu.h added

kib accepted this revision.Aug 5 2020, 6:47 PM
This revision is now accepted and ready to land.Aug 5 2020, 6:47 PM
Closed by commit rS363929: o Add machine/iommu.h and include MD iommu headers from it, (authored by br). · Explain WhyAug 5 2020, 7:11 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS363929: o Add machine/iommu.h and include MD iommu headers from it,.
Herald added subscribers: rpokala, imp. · View Herald TranscriptAug 5 2020, 7:11 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
6 lines
dev/
iommu/
9 lines
4 lines
i386/
include/
6 lines
x86/
include/
13 lines

Diff 75431

View Options

sys/amd64/include/iommu.h

Loading...
View Options

sys/dev/iommu/busdma_iommu.c

Loading...
View Options

sys/dev/iommu/iommu_gas.c

Loading...
View Options

sys/i386/include/iommu.h

Loading...
View Options

sys/x86/include/iommu.h

Loading...