Page MenuHomeFreeBSD
Differential D25894

domain map/unmap vtable
ClosedPublic
Actions

Authored by br on Jul 30 2020, 12:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 6:49 AM
Unknown Object (File)
Wed, Apr 17, 6:48 AM
Unknown Object (File)
Wed, Apr 17, 6:47 AM
Unknown Object (File)
Wed, Apr 17, 5:14 AM
Unknown Object (File)
Wed, Apr 17, 4:59 AM
Unknown Object (File)
Tue, Apr 16, 5:54 AM
Unknown Object (File)
Feb 28 2024, 7:50 PM
Unknown Object (File)
Feb 25 2024, 12:31 AM
View All 43 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS363747: Add iommu_domain_map_ops virtual table with map/unmap methods
Summary

Provide the map/unmap function pointers so we can use different iommus (Intel IOMMU or AMD iommu) on the same platform

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Jul 30 2020, 12:03 PM
br created this revision.
kib added inline comments.Jul 30 2020, 1:59 PM
sys/dev/iommu/iommu.h
134

IMO it is better to define struct iommu_domain_map_ops which would contain the function pointers, and store the pointer to the structure in domain.

sys/dev/iommu/iommu_gas.c
658

I do not think these asserts are useful.

br updated this revision to Diff 75166.Jul 30 2020, 2:56 PM

o Add struct iommu_domain_map_ops
o Remove useless kasserts

kib added inline comments.Jul 30 2020, 10:42 PM
sys/dev/iommu/iommu.h
119

No, I mean that we put a pointer to the struct ops, and then specific IOMMU driver defines const struct ops, pointer to which is stored in the domain. This is how we typically handle all virtual tables.

br updated this revision to Diff 75225.Jul 31 2020, 6:38 PM

struct iommu_domain_map_ops is a pointer, table provided by the driver

br updated this revision to Diff 75226.Jul 31 2020, 6:52 PM

rename dmar_domain_ops -> dmar_domain_map_ops

kib added inline comments.Jul 31 2020, 6:54 PM
sys/x86/iommu/intel_ctx.c
323

static const struct ... ?

sys/x86/iommu/intel_dmar.h
249

Do you need these prototypes after functions are referenced by pointers ?

sys/x86/iommu/intel_idpgtbl.c
688

Can map/unmap now become static ?

br updated this revision to Diff 75232.Jul 31 2020, 9:04 PM

make domain_map/domain_unmap static

sys/x86/iommu/intel_idpgtbl.c
688

they are in different file. So I added domain_pgtbl_init()

kib accepted this revision.Jul 31 2020, 9:13 PM

I am looking at all lines like this:
iodom = (struct iommu_domain *)domain;
and think we need macros like DMAR2IODOM etc.

This revision is now accepted and ready to land.Jul 31 2020, 9:13 PM
Closed by commit rS363747: Add iommu_domain_map_ops virtual table with map/unmap methods (authored by br). · Explain WhyJul 31 2020, 11:02 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS363747: Add iommu_domain_map_ops virtual table with map/unmap methods.
Herald added a subscriber: imp. · View Herald TranscriptJul 31 2020, 11:02 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
iommu/
8 lines
7 lines
x86/
iommu/
7 lines
2 lines
5 lines

Diff 75166

View Options

sys/dev/iommu/iommu.h

Loading...
View Options

sys/dev/iommu/iommu_gas.c

Loading...
View Options

sys/x86/iommu/intel_ctx.c

Loading...
View Options

sys/x86/iommu/intel_dmar.h

Loading...
View Options

sys/x86/iommu/intel_idpgtbl.c

Loading...