domain map/unmap vtable

[br]

Summary

Provide the map/unmap function pointers so we can use different iommus (Intel IOMMU or AMD iommu) on the same platform

[kib]

sys/dev/iommu/iommu.h

126 ↗

(On Diff #75162)

IMO it is better to define struct iommu_domain_map_ops which would contain the function pointers, and store the pointer to the structure in domain.

sys/dev/iommu/iommu_gas.c

659 ↗

(On Diff #75162)

I do not think these asserts are useful.

[br]

o Add struct iommu_domain_map_ops
o Remove useless kasserts

[kib]

sys/dev/iommu/iommu.h

119 ↗

(On Diff #75166)

No, I mean that we put a pointer to the struct ops, and then specific IOMMU driver defines const struct ops, pointer to which is stored in the domain. This is how we typically handle all virtual tables.

[br]

struct iommu_domain_map_ops is a pointer, table provided by the driver

[br]

rename dmar_domain_ops -> dmar_domain_map_ops

[kib]

sys/x86/iommu/intel_ctx.c

323 ↗

(On Diff #75226)

static const struct ... ?

sys/x86/iommu/intel_dmar.h

249 ↗

(On Diff #75226)

Do you need these prototypes after functions are referenced by pointers ?

sys/x86/iommu/intel_idpgtbl.c

688 ↗

(On Diff #75226)

Can map/unmap now become static ?

[br]

make domain_map/domain_unmap static

sys/x86/iommu/intel_idpgtbl.c

688 ↗

(On Diff #75226)

they are in different file. So I added domain_pgtbl_init()

[kib]

I am looking at all lines like this:
iodom = (struct iommu_domain *)domain;
and think we need macros like DMAR2IODOM etc.