Page MenuHomeFreeBSD
Differential D25834

Enable use of the regulator in the Broadcom SDHCI controller
ClosedPublic
Actions

Authored by andrew on Jul 27 2020, 5:39 PM.
Tags
None
Referenced Files
F133158761: D25834.diff
Thu, Oct 23, 12:28 PM
F133158618: D25834.diff
Thu, Oct 23, 12:26 PM
F133155321: D25834.diff
Thu, Oct 23, 11:40 AM
Unknown Object (File)
Mon, Oct 20, 12:50 AM
Unknown Object (File)
Fri, Oct 17, 4:39 PM
Unknown Object (File)
Fri, Oct 17, 3:57 AM
Unknown Object (File)
Sun, Oct 12, 2:11 PM
Unknown Object (File)
Sun, Oct 12, 8:51 AM
View All Files
Subscribers
imp
loos
manu

Details

Reviewers
manu
Group Reviewers
ARM
arm64
Commits
rS363637: Enable use of the regulator in the Broadcom SDHCI controller
Summary

This will be needed before a future GPIO controller driver is added
as the later enaables regulators that leave the SDHCI controller
disabled.

Test Plan

Booted on Raspberry Pi 4

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32599
Build 30055: arc lint + arc unit

Event Timeline

andrew created this revision.Jul 27 2020, 5:39 PM
Herald added a subscriber: loos. · View Herald TranscriptJul 27 2020, 5:39 PM
andrew requested review of this revision.Jul 27 2020, 5:39 PM
Harbormaster completed remote builds in B32582: Diff 75015.Jul 27 2020, 5:39 PM
andrew updated this revision to Diff 75016.Jul 27 2020, 5:46 PM

Remove a newline that creped in

Harbormaster completed remote builds in B32583: Diff 75016.Jul 27 2020, 5:46 PM
manu added a subscriber: manu.Jul 27 2020, 6:08 PM
manu added inline comments.
sys/arm/broadcom/bcm2835/bcm2835_sdhci.c
176

I don't think that you need this one.

andrew updated this revision to Diff 75017.Jul 27 2020, 6:23 PM

Remove an extra mmc_helper

andrew marked an inline comment as done.Jul 27 2020, 6:23 PM
Harbormaster completed remote builds in B32584: Diff 75017.Jul 27 2020, 6:24 PM
manu accepted this revision.Jul 27 2020, 6:30 PM
This revision is now accepted and ready to land.Jul 27 2020, 6:30 PM
manu requested changes to this revision.Jul 27 2020, 6:32 PM

Sorry, I've missed something
You need to change the mmcbr_update_ios in the kobj to point at the new one.

This revision now requires changes to proceed.Jul 27 2020, 6:32 PM
andrew updated this revision to Diff 75045.Jul 28 2020, 9:04 AM

Attach the _ios function

Harbormaster completed remote builds in B32599: Diff 75045.Jul 28 2020, 9:04 AM
manu accepted this revision.Jul 28 2020, 9:26 AM
This revision is now accepted and ready to land.Jul 28 2020, 9:26 AM
Closed by commit rS363637: Enable use of the regulator in the Broadcom SDHCI controller (authored by andrew). · Explain WhyJul 28 2020, 9:47 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rS363637: Enable use of the regulator in the Broadcom SDHCI controller.
Herald added a subscriber: imp. · View Herald TranscriptJul 28 2020, 9:47 AM

Revision Contents
Changeset List

PathSize
sys/
arm/
broadcom/
bcm2835/
36 lines

Diff 75045

View Options

sys/arm/broadcom/bcm2835/bcm2835_sdhci.c

Loading...