Differential D25729

Disable errors for -Wsystem-headers for GCC on aarch64.
ClosedPublic
Actions

Authored by jhb on Jul 19 2020, 8:45 PM.

Details

Reviewers

emaste

Commits

rS363849: Disable errors for -Wsystem-headers for GCC on aarch64.

Summary

GCC's own arm_neon.h triggers multiple warnings on both GCC 6 and GCC 9.

Test Plan

build a world with aarch64-gcc6

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 32419
Build 29896: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 19 2020, 8:45 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptJul 19 2020, 8:45 PM

jhb requested review of this revision.Jul 19 2020, 8:45 PM

Harbormaster completed remote builds in B32419: Diff 74658.Jul 19 2020, 8:45 PM

jhb added a parent revision: D25732: Add a USE_GCC_TOOLCHAINS knob to make universe..Jul 19 2020, 8:49 PM

I reworked this for GCC 9 to instead use -Wno-system-header since GCC 9 had other errors with arm_neon.h.

Just turn off -Wsystem-headers for aarch64 instead for arm_neon.h.

Harbormaster completed remote builds in B32752: Diff 75374.Aug 4 2020, 4:12 PM

jhb retitled this revision from Disable errors for -Wmissing-braces for GCC on aarch64. to Disable errors for -Wsystem-headers for GCC on aarch64..Aug 4 2020, 4:12 PM

jhb edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Aug 4 2020, 6:25 PM

Closed by commit rS363849: Disable errors for -Wsystem-headers for GCC on aarch64. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS363849: Disable errors for -Wsystem-headers for GCC on aarch64..

Herald added a subscriber: imp. · View Herald TranscriptAug 4 2020, 6:25 PM

LGTM

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.sys.mk

5 lines

Diff 74658

View Options

Disable errors for -Wsystem-headers for GCC on aarch64.ClosedPublicActions