Page MenuHomeFreeBSD
Differential D25665

DMAR split-out (part 2)
ClosedPublic
Actions

Authored by br on Jul 14 2020, 1:01 PM.
Tags
None
Referenced Files
F164173899: D25665.id74440.diff
Wed, Jul 29, 8:48 AM
F164090908: D25665.id74517.diff
Tue, Jul 28, 3:30 PM
Unknown Object (File)
Mon, Jul 27, 10:41 AM
Unknown Object (File)
Mon, Jul 27, 3:47 AM
Unknown Object (File)
Thu, Jul 23, 7:56 PM
Unknown Object (File)
Thu, Jul 23, 11:24 AM
Unknown Object (File)
Thu, Jul 23, 12:21 AM
Unknown Object (File)
Tue, Jul 21, 3:10 AM
View All Files
Subscribers
imp
val_packett.cool

Details

Reviewers
kib
Commits
rS363310: o Move iommu_test_boundary() to sys/iommu.h
Summary

o Change DMAR->IOMMU in comments
o Add IOMMU_PAGE_SIZE / IOMMU_PAGE_MASK
o x86 only: dmar_quirks_pre_use() / dmar_instantiate_rmrr_ctxs()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br requested review of this revision.Jul 14 2020, 1:01 PM
br created this revision.
val_packett.cool added a subscriber: val_packett.cool.Jul 14 2020, 5:18 PM
val_packett.cool added inline comments.
sys/x86/iommu/busdma_dmar.c
115 ↗(On Diff #74440)

"I/O Memory Management Unit unit" - maybe no need for that second "unit"..

br updated this revision to Diff 74452.Jul 14 2020, 7:37 PM

Move entries_cnt to iommu_domain.
Move iommu_test_boundary to sys/iommu.h.

br updated this revision to Diff 74517.Jul 16 2020, 1:07 PM

x86 headers included for amd64/x86 only

kib accepted this revision.Jul 17 2020, 9:22 PM
kib added inline comments.
sys/x86/iommu/intel_dmar.h
80 ↗(On Diff #74517)

So what is the plan WRT intel_gas.c, which is probably the most useful MI part of the dmar driver ?

This revision is now accepted and ready to land.Jul 17 2020, 9:22 PM
Closed by commit rS363310: o Move iommu_test_boundary() to sys/iommu.h (authored by br). · Explain WhyJul 18 2020, 1:10 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS363310: o Move iommu_test_boundary() to sys/iommu.h.
Herald added a subscriber: imp. · View Herald TranscriptJul 18 2020, 1:10 PM
br added inline comments.Jul 20 2020, 2:04 PM
sys/x86/iommu/intel_dmar.h
80 ↗(On Diff #74517)

splitting-out GAS is my next step. Please look at this first:
https://reviews.freebsd.org/D25720

Revision Contents
Changeset List

PathSize
head/
sys/
sys/
13 lines
x86/
iommu/
26 lines
11 lines
2 lines
9 lines
3 lines

Diff 74622

View Options

head/sys/sys/iommu.h

Loading...
View Options

head/sys/x86/iommu/busdma_dmar.c

Loading...
View Options

head/sys/x86/iommu/intel_dmar.h

Loading...
View Options

head/sys/x86/iommu/intel_drv.c

Loading...
View Options

head/sys/x86/iommu/intel_gas.c

Loading...
View Options

head/sys/x86/iommu/intel_reg.h

Loading...