Page MenuHomeFreeBSD

DMAR split-out (part 2)
ClosedPublic

Authored by br on Jul 14 2020, 1:01 PM.

Details

Summary

o Change DMAR->IOMMU in comments
o Add IOMMU_PAGE_SIZE / IOMMU_PAGE_MASK
o x86 only: dmar_quirks_pre_use() / dmar_instantiate_rmrr_ctxs()

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

br requested review of this revision.Jul 14 2020, 1:01 PM
br created this revision.
greg_unrelenting.technology added inline comments.
sys/x86/iommu/busdma_dmar.c
118

"I/O Memory Management Unit unit" - maybe no need for that second "unit"..

Move entries_cnt to iommu_domain.
Move iommu_test_boundary to sys/iommu.h.

x86 headers included for amd64/x86 only

kib added inline comments.
sys/x86/iommu/intel_dmar.h
80

So what is the plan WRT intel_gas.c, which is probably the most useful MI part of the dmar driver ?

This revision is now accepted and ready to land.Jul 17 2020, 9:22 PM
This revision was automatically updated to reflect the committed changes.
sys/x86/iommu/intel_dmar.h
80

splitting-out GAS is my next step. Please look at this first:
https://reviews.freebsd.org/D25720