at(1): Fix location of system crontab
ClosedPublic
Actions

Authored by debdrup on Jul 17 2020, 5:36 PM.

Details

Reviewers

Group Reviewers

manpages
docs

Commits

rS363286: at(1): Fix location of at(1) crontab

Summary

With r318443, atrun was moved from /etc/crontab to /etc/cron.d/at,
but the man-page was unfortunately not updated to reflect this.

PR: 248048
Reported by: yoitsmeremember+fbsd at gmail.com

Test Plan

Tested with mandoc

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

debdrup created this revision.Jul 17 2020, 5:36 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 17 2020, 5:36 PM

debdrup requested review of this revision.Jul 17 2020, 5:36 PM

Harbormaster completed remote builds in B32384: Diff 74583.Jul 17 2020, 5:36 PM

Wordsmith the sentente to match behaviour described in r318443

Harbormaster completed remote builds in B32385: Diff 74584.Jul 17 2020, 5:50 PM

pauamma_gundo.com added a subscriber: pauamma_gundo.com.Jul 17 2020, 6:20 PM

pauamma_gundo.com added inline comments.

usr.bin/at/at.man
216 ↗	(On Diff #74584)	Since you're touching that line anyway, maybe s/finer granularity/shorter interval/ at the same time?

debdrup marked an inline comment as done.Jul 17 2020, 6:37 PM

debdrup added inline comments.

usr.bin/at/at.man
216 ↗	(On Diff #74584)	It's not just a shorter interval that 'at' offers, it can be at 4 minutes 42 seconds or 5 minutes 42 seconds - so finer granularity is the correct wording.

allanjude accepted this revision.Jul 17 2020, 8:41 PM

This revision is now accepted and ready to land.Jul 17 2020, 8:41 PM

Closed by commit rS363286: at(1): Fix location of at(1) crontab (authored by allanjude). · Explain WhyJul 17 2020, 8:43 PM

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rS363286: at(1): Fix location of at(1) crontab.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

at/

at.man

7 lines

Diff 74593

View Options

head/usr.bin/at/at.man

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines

#ifdef DDB		#ifdef DDB
#include <ddb/ddb.h>		#include <ddb/ddb.h>
#include <ddb/db_sym.h>		#include <ddb/db_sym.h>
#endif		#endif

/* Called from exception.S */		/* Called from exception.S */
void do_el1h_sync(struct thread , struct trapframe );		void do_el1h_sync(struct thread , struct trapframe );
void do_el0_sync(struct thread , struct trapframe , uint64_t far);		void do_el0_sync(struct thread , struct trapframe );
void do_el0_error(struct trapframe *);		void do_el0_error(struct trapframe *);
void do_serror(struct trapframe *);		void do_serror(struct trapframe *);
void unhandled_exception(struct trapframe *);		void unhandled_exception(struct trapframe *);

static void print_gp_register(const char *name, uint64_t value);		static void print_gp_register(const char *name, uint64_t value);
static void print_registers(struct trapframe *frame);		static void print_registers(struct trapframe *frame);

int (dtrace_invop_jump_addr)(struct trapframe );		int (dtrace_invop_jump_addr)(struct trapframe );
▲ Show 20 Lines • Show All 372 Lines • ▼ Show 20 Lines
*/		*/
void NO_PERTHREAD_SSP		void NO_PERTHREAD_SSP
do_el1h_sync(struct thread td, struct trapframe frame)		do_el1h_sync(struct thread td, struct trapframe frame)
{		{
uint32_t exception;		uint32_t exception;
uint64_t esr, far;		uint64_t esr, far;
int dfsc;		int dfsc;

		far = frame->tf_far;
/* Read the esr register to get the exception details */		/* Read the esr register to get the exception details */
esr = frame->tf_esr;		esr = frame->tf_esr;
exception = ESR_ELx_EXCEPTION(esr);		exception = ESR_ELx_EXCEPTION(esr);

#ifdef KDTRACE_HOOKS		#ifdef KDTRACE_HOOKS
if (dtrace_trap_func != NULL && (*dtrace_trap_func)(frame, exception))		if (dtrace_trap_func != NULL && (*dtrace_trap_func)(frame, exception))
return;		return;
#endif		#endif
Show All 21 Lines	#endif
{		{
print_registers(frame);		print_registers(frame);
printf(" esr: %.16lx\n", esr);		printf(" esr: %.16lx\n", esr);
panic("VFP exception in the kernel");		panic("VFP exception in the kernel");
}		}
break;		break;
case EXCP_INSN_ABORT:		case EXCP_INSN_ABORT:
case EXCP_DATA_ABORT:		case EXCP_DATA_ABORT:
far = READ_SPECIALREG(far_el1);
dfsc = esr & ISS_DATA_DFSC_MASK;		dfsc = esr & ISS_DATA_DFSC_MASK;
if (dfsc < nitems(abort_handlers) &&		if (dfsc < nitems(abort_handlers) &&
abort_handlers[dfsc] != NULL) {		abort_handlers[dfsc] != NULL) {
abort_handlers[dfsc](td, frame, esr, far, 0);		abort_handlers[dfsc](td, frame, esr, far, 0);
} else {		} else {
print_registers(frame);		print_registers(frame);
print_gp_register("far", far);		print_gp_register("far", far);
printf(" esr: %.16lx\n", esr);		printf(" esr: %.16lx\n", esr);
Show All 22 Lines	#ifdef KDB
kdb_trap(exception, 0, frame);		kdb_trap(exception, 0, frame);
#else		#else
panic("No debugger in kernel.");		panic("No debugger in kernel.");
#endif		#endif
break;		break;
case EXCP_FPAC:		case EXCP_FPAC:
/* We can see this if the authentication on PAC fails */		/* We can see this if the authentication on PAC fails */
print_registers(frame);		print_registers(frame);
printf(" far: %16lx\n", READ_SPECIALREG(far_el1));		print_gp_register("far", far);
panic("FPAC kernel exception");		panic("FPAC kernel exception");
break;		break;
case EXCP_UNKNOWN:		case EXCP_UNKNOWN:
if (undef_insn(1, frame))		if (undef_insn(1, frame))
break;		break;
printf("Undefined instruction: %08x\n",		printf("Undefined instruction: %08x\n",
(uint32_t )frame->tf_elr);		(uint32_t )frame->tf_elr);
/* FALLTHROUGH */		/* FALLTHROUGH */
default:		default:
print_registers(frame);		print_registers(frame);
print_gp_register("far", READ_SPECIALREG(far_el1));		print_gp_register("far", far);
panic("Unknown kernel exception %x esr_el1 %lx", exception,		panic("Unknown kernel exception %x esr_el1 %lx", exception,
esr);		esr);
}		}
}		}

void		void
do_el0_sync(struct thread td, struct trapframe frame, uint64_t far)		do_el0_sync(struct thread td, struct trapframe frame)
{		{
pcpu_bp_harden bp_harden;		pcpu_bp_harden bp_harden;
uint32_t exception;		uint32_t exception;
uint64_t esr;		uint64_t esr, far;
int dfsc;		int dfsc;

/* Check we have a sane environment when entering from userland */		/* Check we have a sane environment when entering from userland */
KASSERT((uintptr_t)get_pcpu() >= VM_MIN_KERNEL_ADDRESS,		KASSERT((uintptr_t)get_pcpu() >= VM_MIN_KERNEL_ADDRESS,
("Invalid pcpu address from userland: %p (tpidr %lx)",		("Invalid pcpu address from userland: %p (tpidr %lx)",
get_pcpu(), READ_SPECIALREG(tpidr_el1)));		get_pcpu(), READ_SPECIALREG(tpidr_el1)));

		far = frame->tf_far;
esr = frame->tf_esr;		esr = frame->tf_esr;
exception = ESR_ELx_EXCEPTION(esr);		exception = ESR_ELx_EXCEPTION(esr);
if (exception == EXCP_INSN_ABORT_L && far > VM_MAXUSER_ADDRESS) {		if (exception == EXCP_INSN_ABORT_L && far > VM_MAXUSER_ADDRESS) {
/*		/*
* Userspace may be trying to train the branch predictor to		* Userspace may be trying to train the branch predictor to
* attack the kernel. If we are on a CPU affected by this		* attack the kernel. If we are on a CPU affected by this
* call the handler to clear the branch predictor state.		* call the handler to clear the branch predictor state.
*/		*/
▲ Show 20 Lines • Show All 124 Lines • ▼ Show 20 Lines
/*		/*
* TODO: We will need to handle these later when we support ARMv8.2 RAS.		* TODO: We will need to handle these later when we support ARMv8.2 RAS.
*/		*/
void		void
do_serror(struct trapframe *frame)		do_serror(struct trapframe *frame)
{		{
uint64_t esr, far;		uint64_t esr, far;

far = READ_SPECIALREG(far_el1);		far = frame->tf_far;
esr = frame->tf_esr;		esr = frame->tf_esr;

print_registers(frame);		print_registers(frame);
print_gp_register("far", far);		print_gp_register("far", far);
printf(" esr: %.16lx\n", esr);		printf(" esr: %.16lx\n", esr);
panic("Unhandled System Error");		panic("Unhandled System Error");
}		}

void		void
unhandled_exception(struct trapframe *frame)		unhandled_exception(struct trapframe *frame)
{		{
uint64_t esr, far;		uint64_t esr, far;

far = READ_SPECIALREG(far_el1);		far = frame->tf_far;
esr = frame->tf_esr;		esr = frame->tf_esr;

print_registers(frame);		print_registers(frame);
print_gp_register("far", far);		print_gp_register("far", far);
printf(" esr: %.16lx\n", esr);		printf(" esr: %.16lx\n", esr);
panic("Unhandled exception");		panic("Unhandled exception");
}		}

at(1): Fix location of system crontabClosedPublicActions