Page MenuHomeFreeBSD
Differential D25628

add backup of efi partition for daily periodic
ClosedPublic
Actions

Authored by rew on Jul 11 2020, 6:55 PM.
Tags
None
Referenced Files
F155026239: D25628.id74338.diff
Thu, Apr 30, 6:43 PM
F154954041: D25628.id74330.diff
Thu, Apr 30, 7:24 AM
Unknown Object (File)
Thu, Apr 23, 8:44 AM
Unknown Object (File)
Wed, Apr 22, 11:00 PM
Unknown Object (File)
Wed, Apr 22, 6:50 PM
Unknown Object (File)
Tue, Apr 21, 5:40 AM
Unknown Object (File)
Tue, Apr 21, 12:28 AM
Unknown Object (File)
Mon, Apr 20, 2:43 AM
View All Files
Subscribers
allanjude
imp

Details

Reviewers
allanjude
Group Reviewers
manpages
Commits
rS368507: MFC r363110 (by allanjude):
rS363110: Add a periodic script to backup the partition table and boot code
Summary

bug squash 2020

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=86388

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32258
Build 29748: arc lint + arc unit

Event Timeline

rew requested review of this revision.Jul 11 2020, 6:55 PM
rew created this revision.
Harbormaster completed remote builds in B32258: Diff 74330.Jul 11 2020, 6:55 PM
allanjude added a subscriber: allanjude.Jul 11 2020, 7:06 PM

Can we also add the variables to the usr.sbin/periodic/periodic.conf defaults file. We likely want daily_backup_gpart_enable="YES" but daily_backup_gpart_verbose="NO" and daily_backup_efi_enable="NO"

Each of these variables will also need to be added to share/man/man5/periodic.conf.5

usr.sbin/periodic/etc/daily/221.backup-gpart
100

Since the EFI partition might be 250+ MB, we might want to give this its own enable/disable flag

rew updated this revision to Diff 74336.Jul 11 2020, 8:35 PM
  • Document changes for new periodic variables in periodic.conf(5). Set defaults for new variables in periodic.conf.
Harbormaster completed remote builds in B32262: Diff 74336.Jul 11 2020, 8:35 PM
allanjude accepted this revision.Jul 11 2020, 8:38 PM
allanjude added inline comments.
share/man/man5/periodic.conf.5
259 ↗(On Diff #74336)

This creates a backup of the contents of the EFI System partition (boot code), not the partition table

This revision is now accepted and ready to land.Jul 11 2020, 8:38 PM
Closed by commit rS363110: Add a periodic script to backup the partition table and boot code (authored by allanjude). · Explain WhyJul 11 2020, 8:53 PM
This revision was automatically updated to reflect the committed changes.
allanjude added a commit: rS363110: Add a periodic script to backup the partition table and boot code.
Herald added a reviewer: manpages. · View Herald TranscriptJul 11 2020, 8:53 PM
Herald added a subscriber: imp. · View Herald Transcript
gbe added a commit: rS368507: MFC r363110 (by allanjude):.Dec 10 2020, 9:55 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
periodic/
etc/
daily/
119 lines

Diff 74330

View Options

usr.sbin/periodic/etc/daily/221.backup-gpart

Loading...