geom_label: Make glabel labels more trivial by separating the tasting routines out.
ClosedPublic
Actions

Authored by delphij on Jul 9 2020, 7:29 AM.

Details

Reviewers

cem
pjd
mav
imp

Commits

rS363537: geom_label: Make glabel labels more trivial by separating the tasting

Summary

While there, also simplify the creation of label paths a little bit
by requiring the / suffix for label directory prefixes (ld_dir renamed
to ld_dirprefix to indicate the change) and stop defining macros for
these when they are only used once.

Test Plan

test glabel behavior after change

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32211
Build 29707: arc lint + arc unit

Event Timeline

delphij requested review of this revision.Jul 9 2020, 7:29 AM

delphij created this revision.

Harbormaster completed remote builds in B32211: Diff 74224.Jul 9 2020, 7:29 AM

@cem -- Note that D24968 needs to be amended due to conflict (I have it locally with an amendment to D25168 to make geli detach -l work again with aliases), I've uploaded these to https://github.com/delphij/freebsd/commits/scratch/geom .

delphij retitled this revision from geom_label: Make glabel labels more trivial by separating the tasting rounttnes out. to geom_label: Make glabel labels more trivial by separating the tasting routines out..Jul 9 2020, 7:40 AM

delphij added reviewers: mav, imp.Jul 13 2020, 6:39 AM

In D25597#566273, @delphij wrote:

@cem -- Note that D24968 needs to be amended due to conflict (I have it locally with an amendment to D25168 to make geli detach -l work again with aliases), I've uploaded these to https://github.com/delphij/freebsd/commits/scratch/geom .

No worries, thanks for keeping it in mind.

This change looks good to me, sorry about the delay.