Paths

Table of Contentst

Differential D25575

timeout(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Jul 6 2020, 6:31 PM.

Tags

None

Referenced Files

	F167204816: D25575.id74160.diff
	Wed, Aug 19, 10:34 PM

	Unknown Object (File)
	Tue, Aug 18, 4:33 PM

	Unknown Object (File)
	Fri, Aug 14, 6:47 PM

	Unknown Object (File)
	Fri, Aug 14, 5:07 PM

	Unknown Object (File)
	Thu, Aug 13, 9:09 PM

	Unknown Object (File)
	Thu, Aug 13, 9:09 PM

	Unknown Object (File)
	Thu, Aug 13, 9:09 PM

	Unknown Object (File)
	Sun, Aug 9, 12:22 PM

Subscribers

Contributor Reviews (src)

Details

Reviewers

Group Reviewers

Commits

rS362994: timeout(1): Add EXAMPLES section

Summary

Small EXAMPLES section showing the use of -s, -k and the different exit

status.

Deliberately not bumping .Dd in the review

Test Plan

mandoc -Tlint clean
igor clean
aspell happy
man ./timeout.1 renders the page properly

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32179
Build 29679: arc lint + arc unit

Event Timeline

fernape created this revision.Jul 6 2020, 6:31 PM

Herald added a reviewer: manpages. · View Herald TranscriptJul 6 2020, 6:31 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

fernape requested review of this revision.Jul 6 2020, 6:31 PM

Harbormaster completed remote builds in B32160: Diff 74126.Jul 6 2020, 6:31 PM

gbe added a subscriber: gbe.Jul 7 2020, 5:44 AM

gbe added inline comments.

usr.bin/timeout/timeout.1
183	I think that "the single page version of the" would be more correct here since the term single page in context of a book somehow implies "a single page of a book".

Improve wording as suggested by gbe@

Harbormaster completed remote builds in B32179: Diff 74154.Jul 7 2020, 4:04 PM

Thanks for incorporating the suggested changes. I verified the examples and everything looks like a LGTM now.

This revision is now accepted and ready to land.Jul 7 2020, 4:13 PM

Closed by commit rS362994: timeout(1): Add EXAMPLES section (authored by fernape). · Explain WhyJul 7 2020, 5:02 PM

This revision was automatically updated to reflect the committed changes.

fernape added a commit: rS362994: timeout(1): Add EXAMPLES section.

In D25575#565865, @gbe wrote:

Thanks for incorporating the suggested changes. I verified the examples and everything looks like a LGTM now.

Thanks (again!) for reviewing this.

Revision Contents
Changeset List

Path

Size

usr.bin/

timeout/

56 lines

Diff 74154

usr.bin/timeout/timeout.1

Loading...