riscv locore.S: load constant prior to loop
ClosedPublic
Actions

Authored by freebsdphab-AX9_cmx.ietfng.org on Jun 30 2020, 8:13 PM.

Details

Reviewers

br
mhorne

Commits

rS362852: riscv locore.S: load constant prior to loop

Summary

A very minor micro-optimization; t0 is not clobbered between the loop top and bottom and there appear to be no other branches to this label.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freebsdphab-AX9_cmx.ietfng.org created this revision.Jun 30 2020, 8:13 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJun 30 2020, 8:13 PM

freebsdphab-AX9_cmx.ietfng.org requested review of this revision.Jun 30 2020, 8:13 PM

freebsdphab-AX9_cmx.ietfng.org edited the summary of this revision. (Show Details)

freebsdphab-AX9_cmx.ietfng.org added a reviewer: br.

freebsdphab-AX9_cmx.ietfng.org added a project: riscv.

Hi, thank you for the patch. It looks good.

In the future, please upload diffs with full context. It makes them easier to review. To do so, run git show -U99999, or use the arcanist tool.

Could you confirm your name and email address for the "Submitted by:" tag in the commit?

Submitted by: Nathaniel Filardo <nwf20@cl.cam.ac.uk>

This revision is now accepted and ready to land.Jul 1 2020, 2:02 PM

Yes, that's a fine "Submitted by".

Thanks for the tip about full context.

mhorne mentioned this in D25523: riscv pmap: zero reserved pte bits in ppn.Jul 1 2020, 5:45 PM

Closed by commit rS362852: riscv locore.S: load constant prior to loop (authored by kp). · Explain WhyJul 1 2020, 7:13 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rS362852: riscv locore.S: load constant prior to loop.

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

locore.S

2 lines

Diff 73987

View Options

head/sys/riscv/riscv/locore.S

riscv locore.S: load constant prior to loopClosedPublicActions