Fix fallout from the emancipation of dump(8) workers
ClosedPublic
Actions

Authored by cperciva on Jun 22 2020, 8:37 PM.

Details

Reviewers

imp
cem
danfe

Commits

rS362557: Clean up some function and variable names.

Summary

The change from "slave" processes to "minion" processes to "worker" processes left some less-than-coherent names:

"enslave" turned into the ungrammatical "enworker".
"slp" (SLave Pointer) turned into "mlp" (Minion [L] Pointer?).

Convert "enworker" to "create_workers" (the function in question forks off 3 worker processes), and replace "mlp" with "wp" (Worker Pointer) and "tmlp" with "twp" (Temporary Worker Pointer).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva requested review of this revision.Jun 22 2020, 8:37 PM

cperciva created this revision.

Harbormaster completed remote builds in B31880: Diff 73475.Jun 22 2020, 8:37 PM

Thanks for taking care of this Colin. The diff looks fine at a quick glance.

Diff looks good to me, thanks. I would suggest not using "emancipation" in the commit subject.

This revision is now accepted and ready to land.Jun 22 2020, 8:50 PM

Thanks Colin!

Closed by commit rS362557: Clean up some function and variable names. (authored by cperciva). · Explain WhyJun 23 2020, 9:11 PM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rS362557: Clean up some function and variable names..

Thanks for this cleanup. I found the previous transformation grating for the reasons that you listed.

Revision Contents
Changeset List

Path

Size

head/

sbin/

dump/

tape.c

122 lines

Diff 73548

View Options

Fix fallout from the emancipation of dump(8) workersClosedPublicActions