Page MenuHomeFreeBSD

Fix fallout from the emancipation of dump(8) workers

Authored by cperciva on Jun 22 2020, 8:37 PM.
Referenced Files
Unknown Object (File)
Thu, Jan 12, 7:01 PM
Unknown Object (File)
Dec 20 2022, 11:05 PM
Unknown Object (File)
Nov 26 2022, 11:55 PM



The change from "slave" processes to "minion" processes to "worker" processes left some less-than-coherent names:

  1. "enslave" turned into the ungrammatical "enworker".
  2. "slp" (SLave Pointer) turned into "mlp" (Minion [L] Pointer?).

Convert "enworker" to "create_workers" (the function in question forks off 3 worker processes), and replace "mlp" with "wp" (Worker Pointer) and "tmlp" with "twp" (Temporary Worker Pointer).

Diff Detail

Lint Skipped
Tests Skipped
Build Status
Buildable 31880

Event Timeline

cperciva created this revision.

Thanks for taking care of this Colin. The diff looks fine at a quick glance.

Diff looks good to me, thanks. I would suggest not using "emancipation" in the commit subject.

This revision is now accepted and ready to land.Jun 22 2020, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Thanks for this cleanup. I found the previous transformation grating for the reasons that you listed.