Page MenuHomeFreeBSD
Differential D25344

comm(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Jun 18 2020, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 11:18 AM
Unknown Object (File)
Thu, Apr 18, 1:38 AM
Unknown Object (File)
Mar 4 2024, 4:46 PM
Unknown Object (File)
Dec 28 2023, 4:10 AM
Unknown Object (File)
Dec 20 2023, 7:01 AM
Unknown Object (File)
Jul 5 2023, 1:38 AM
Unknown Object (File)
Jul 5 2023, 1:37 AM
Unknown Object (File)
Jul 5 2023, 1:37 AM
View All 17 Files
Subscribers
gbe
imp
Contributor Reviews (src)

Details

Reviewers
gbe
Group Reviewers
manpages
Commits
rS363620: comm(1): Add EXAMPLES section
Summary

Two very simple examples for this utility, but I honestly thing it is better
than not having examples at all :-)

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./comm.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31895
Build 29448: arc lint + arc unit

Event Timeline

fernape created this revision.Jun 18 2020, 4:33 PM
Herald added a reviewer: manpages. · View Herald TranscriptJun 18 2020, 4:33 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Jun 18 2020, 4:33 PM
Harbormaster completed remote builds in B31803: Diff 73280.Jun 18 2020, 4:33 PM
fernape updated this revision to Diff 73508.Jun 23 2020, 10:08 AM

Use \e instead of manually escaping characters

Harbormaster completed remote builds in B31894: Diff 73508.Jun 23 2020, 10:08 AM
fernape updated this revision to Diff 73509.Jun 23 2020, 10:09 AM

Properly updating review.

Using \e instead of manually escaping characters

Harbormaster completed remote builds in B31895: Diff 73509.Jun 23 2020, 10:09 AM
gbe added a subscriber: gbe.Jul 12 2020, 8:56 AM
gbe added inline comments.
usr.bin/comm/comm.1
113

When I try the example, I got a different output. See below,

$ echo -e "B\nc" | comm ~/tmp/example.txt -
a
b
	B
		c
d
fernape added inline comments.Jul 21 2020, 4:08 PM
usr.bin/comm/comm.1
113

Sorry for the delay, I took some days off and went AFK :-)

Strange, I get this:

[fernape@vm-current ~]$ cat example.txt
a
b
c
d
[fernape@vm-current ~]$ echo -e "B\nc" | comm example.txt -
        B
a
b
                c
d
[fernape@vm-current ~]$ uname -a
FreeBSD vm-current 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r362494: Mon Jun 22 20:26:42 CEST 2020     root@vm-current:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64

and exactly the same output in 12.1-RELEASE.

I suspect it might be the environment. In my case, the variables that affect the behavior of comm(1) are cleared:

$ echo $LANG $LC_ALL $LC_COLLATE $LC_CTYPE
$
fernape added a comment.Jul 27 2020, 3:29 PM

This is the output from freefall

[fernape@freefall ~]$ echo -e "B\nc" | comm example.txt -
        B
a
b
                c
d
[fernape@freefall ~]$ uname -a
FreeBSD freefall.freebsd.org 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r360534: Fri May  1 17:50:03 UTC 2020     sbruno@build-13.freebsd.org:/usr/obj/usr/src/sys/CLUSTER13  amd64
gbe accepted this revision.Jul 27 2020, 3:55 PM
In D25344#572178, @fernape wrote:

This is the output from freefall

[fernape@freefall ~]$ echo -e "B\nc" | comm example.txt -
        B
a
b
                c
d
[fernape@freefall ~]$ uname -a
FreeBSD freefall.freebsd.org 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r360534: Fri May  1 17:50:03 UTC 2020     sbruno@build-13.freebsd.org:/usr/obj/usr/src/sys/CLUSTER13  amd64

I have some language settings for german umlauts active, but I didn't remember which ones. So I would think that this differential is fine.

This revision is now accepted and ready to land.Jul 27 2020, 3:55 PM
Closed by commit rS363620: comm(1): Add EXAMPLES section (authored by fernape). · Explain WhyJul 27 2020, 4:51 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rS363620: comm(1): Add EXAMPLES section.
fernape added a comment.Jul 27 2020, 4:52 PM
In D25344#572188, @gbe wrote:
In D25344#572178, @fernape wrote:

This is the output from freefall

[fernape@freefall ~]$ echo -e "B\nc" | comm example.txt -
        B
a
b
                c
d
[fernape@freefall ~]$ uname -a
FreeBSD freefall.freebsd.org 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r360534: Fri May  1 17:50:03 UTC 2020     sbruno@build-13.freebsd.org:/usr/obj/usr/src/sys/CLUSTER13  amd64

I have some language settings for german umlauts active, but I didn't remember which ones. So I would think that this differential is fine.

Thanks for reviewing this!

Revision Contents
Changeset List

PathSize
usr.bin/
comm/
33 lines

Diff 73509

View Options

usr.bin/comm/comm.1

Loading...