Fix reboot command on the Raspberry Pi series.
ClosedPublic
Actions

Authored by crowston_protonmail.com on Jun 14 2020, 3:46 PM.

Details

Reviewers

manu
andrew

Commits

rS362489: Fix reboot command on the Raspberry Pi series.

Summary

The Raspbery Pi computers do not properly implement PSCI. The canonical
way to reset them is to set a watchdog timer and allow it to expire.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31698
Build 29269: arc lint + arc unit

Event Timeline

crowston_protonmail.com created this revision.Jun 14 2020, 3:46 PM

Herald added a subscriber: andrew. · View Herald TranscriptJun 14 2020, 3:46 PM

Harbormaster completed remote builds in B31698: Diff 73109.Jun 14 2020, 3:46 PM

crowston_protonmail.com requested review of this revision.Jun 14 2020, 3:46 PM

Adding manu for his embedded expertise (more than mine anyway). :)

andrew accepted this revision.Jun 15 2020, 5:36 PM

This revision is now accepted and ready to land.Jun 15 2020, 5:36 PM

Is there a process to follow to get this change from "accepted" to committed?

@manu: Can you take care of this? Thanks!

In D25268#559920, @crowston_protonmail.com wrote:

Is there a process to follow to get this change from "accepted" to committed?

I'll commit it on Monday. I was giving other people a chance to review.

Thank you.

Closed by commit rS362489: Fix reboot command on the Raspberry Pi series. (authored by andrew). · Explain WhyJun 22 2020, 8:12 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rS362489: Fix reboot command on the Raspberry Pi series..

Herald added a subscriber: imp. · View Herald TranscriptJun 22 2020, 8:12 AM

Revision Contents
Changeset List

Path

Size

sys/

arm/

broadcom/

bcm2835/

bcm2835_wdog.c

40 lines

Diff 73109

View Options

sys/arm/broadcom/bcm2835/bcm2835_wdog.c

Fix reboot command on the Raspberry Pi series.ClosedPublicActions