PR 219829 Handle device removal and removal+add cases to fix infinity rate.
ClosedPublic
Actions

Authored by ota_j.email.ne.jp on Jun 11 2020, 3:05 AM.

Details

Reviewers

mr
f20190109_eeeit.de

Group Reviewers

manpages

Commits

rS365364: MFC r363095:
rS363095: Handle device removal and removal+add cases to fix infinity rate.

Summary

The problem happens when a device is 1. removed, 2. removed and added back,
and 3. removed and a different one is added.

The case 2 applies to PR 219829 case.
One can reproduce the problem by creating, using, and destroying wlan or
tap devises as these are the easy one to add and remove on the fly.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219829

Test Plan

Set up an interface that can be destroyed like tap or wlan.
% systat -if 1
% ifconfig wlan0 destroy
% ifconfig ... etc to recreate wlan0

This makes the some devices' peak too high.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31650
Build 29229: arc lint + arc unit

Event Timeline

ota_j.email.ne.jp created this revision.Jun 11 2020, 3:05 AM

Herald added a reviewer: manpages. · View Herald TranscriptJun 11 2020, 3:05 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

Harbormaster completed remote builds in B31630: Diff 72966.Jun 11 2020, 3:05 AM

ota_j.email.ne.jp requested review of this revision.Jun 11 2020, 3:05 AM

ota_j.email.ne.jp added a reviewer: mr.Jun 11 2020, 3:39 AM

ota_j.email.ne.jp retitled this revision from PR 219829 -Handle device removal and removal+add cases to fix infinity rate. to PR 219829 Handle device removal and removal+add cases to fix infinity rate..Jun 11 2020, 3:41 AM

ota_j.email.ne.jp edited the summary of this revision. (Show Details)