Page MenuHomeFreeBSD
Differential D25152

sys/riscv: Remove debug printfs
ClosedPublic
Actions

Authored by arichardson on Jun 5 2020, 5:19 PM.
Tags
None
Referenced Files
F170558446: D25152.id.diff
Sat, Sep 5, 10:00 AM
F170508424: D25152.diff
Sat, Sep 5, 3:58 AM
F170461913: D25152.id.diff
Fri, Sep 4, 10:46 PM
Unknown Object (File)
Thu, Sep 3, 12:36 AM
Unknown Object (File)
Wed, Sep 2, 4:48 PM
Unknown Object (File)
Wed, Sep 2, 8:12 AM
Unknown Object (File)
Wed, Sep 2, 7:25 AM
Unknown Object (File)
Tue, Sep 1, 2:01 PM
View All Files
Subscribers
imp
jrtc27
mhorne

Details

Reviewers
br
mhorne
Group Reviewers
riscv
Commits
rS361904: sys/riscv: Remove debug printfs
Summary

They are only visible with EARLY_PRINTF so don't show up by default.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Jun 5 2020, 5:19 PM
arichardson created this revision.
Harbormaster completed remote builds in B31513: Diff 72724.Jun 5 2020, 5:19 PM
arichardson added inline comments.Jun 5 2020, 5:19 PM
sys/riscv/riscv/pmap.c
565 ↗(On Diff #72724)

Should this one also be deleted?

jrtc27 added a subscriber: jrtc27.Jun 5 2020, 5:25 PM

FWIW, this series of three printf's was copied directly from arm64's pmap_bootstrap.

mhorne accepted this revision.Jun 5 2020, 5:42 PM
mhorne added a subscriber: mhorne.
mhorne added inline comments.
sys/riscv/riscv/pmap.c
565 ↗(On Diff #72724)

I'd vote for it to stay, I've used it for debugging before.

This revision is now accepted and ready to land.Jun 5 2020, 5:42 PM
Closed by commit rS361904: sys/riscv: Remove debug printfs (authored by arichardson). · Explain WhyJun 8 2020, 8:52 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rS361904: sys/riscv: Remove debug printfs.
Herald added a subscriber: imp. · View Herald TranscriptJun 8 2020, 8:52 AM

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
riscv/
2 lines

Diff 72815

View Options

head/sys/riscv/riscv/pmap.c

Loading...