sys/riscv: Remove debug printfs
ClosedPublic
Actions

Authored by arichardson on Jun 5 2020, 5:19 PM.

Tags

None

Referenced Files

	F170933429: D25152.id72815.diff
	Mon, Sep 7, 5:06 PM

	F170865606: D25152.id72724.diff
	Mon, Sep 7, 3:19 AM

	F170835734: D25152.id72815.diff
	Sun, Sep 6, 10:46 PM

	F170828309: D25152.id72815.diff
	Sun, Sep 6, 9:27 PM

	Unknown Object (File)
	Sun, Sep 6, 6:25 AM

	Unknown Object (File)
	Sun, Sep 6, 5:57 AM

	Unknown Object (File)
	Sun, Sep 6, 5:45 AM

	Unknown Object (File)
	Sun, Sep 6, 4:22 AM

Subscribers

Details

Reviewers

br
mhorne

Group Reviewers

riscv

Commits

rS361904: sys/riscv: Remove debug printfs

Summary

They are only visible with EARLY_PRINTF so don't show up by default.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31513
Build 29117: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Jun 5 2020, 5:19 PM

arichardson created this revision.

Harbormaster completed remote builds in B31513: Diff 72724.Jun 5 2020, 5:19 PM

arichardson added inline comments.Jun 5 2020, 5:19 PM

sys/riscv/riscv/pmap.c
565	Should this one also be deleted?

FWIW, this series of three printf's was copied directly from arm64's pmap_bootstrap.

mhorne accepted this revision.Jun 5 2020, 5:42 PM

mhorne added a subscriber: mhorne.

mhorne added inline comments.

sys/riscv/riscv/pmap.c
565	I'd vote for it to stay, I've used it for debugging before.

This revision is now accepted and ready to land.Jun 5 2020, 5:42 PM

Closed by commit rS361904: sys/riscv: Remove debug printfs (authored by arichardson). · Explain WhyJun 8 2020, 8:52 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS361904: sys/riscv: Remove debug printfs.

Herald added a subscriber: imp. · View Herald TranscriptJun 8 2020, 8:52 AM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

pmap.c

2 lines

Diff 72724

View Options

sys/riscv: Remove debug printfsClosedPublicActions