Page MenuHomeFreeBSD
Differential D25140

Fix AES-CCM requests with an AAD size smaller than a single block.
ClosedPublic
Actions

Authored by jhb on Jun 4 2020, 11:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 4, 6:14 PM
Unknown Object (File)
Sat, Oct 3, 8:38 PM
Unknown Object (File)
Wed, Sep 30, 11:56 PM
Unknown Object (File)
Wed, Sep 30, 10:40 AM
Unknown Object (File)
Fri, Sep 11, 5:48 AM
Unknown Object (File)
Mon, Sep 7, 4:12 PM
Unknown Object (File)
Mon, Sep 7, 1:43 AM
Unknown Object (File)
Sun, Sep 6, 9:26 PM
View All Files
Subscribers
imp
sef

Details

Reviewers
cem
jmg
Commits
rS362123: Fix AES-CCM requests with an AAD size smaller than a single block.
Summary

The amount to copy for the first block is the minimum of the size of the
AAD region or the remaining space in the first block.

Test Plan
  • cryptocheck -a aead -d aesni0 -z failed these requests with bad tags before and now the tags match

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31501
Build 29107: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jun 4 2020, 11:08 PM
jhb created this revision.
Harbormaster completed remote builds in B31501: Diff 72699.Jun 4 2020, 11:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 9:33 PM
Closed by commit rS362123: Fix AES-CCM requests with an AAD size smaller than a single block. (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS362123: Fix AES-CCM requests with an AAD size smaller than a single block..
Herald added a reviewer: jmg. · View Herald TranscriptJun 12 2020, 9:33 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
sys/
crypto/
aesni/
2 lines

Diff 72699

View Options

sys/crypto/aesni/aesni_ccm.c

Loading...