Fix AES-CCM requests with an AAD size smaller than a single block.
ClosedPublic
Actions

Authored by jhb on Jun 4 2020, 11:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 6, 3:32 AM

	Unknown Object (File)
	Sun, Apr 5, 7:27 AM

	Unknown Object (File)
	Tue, Mar 31, 6:02 PM

	Unknown Object (File)
	Tue, Mar 31, 1:49 AM

	Unknown Object (File)
	Wed, Mar 25, 7:38 AM

	Unknown Object (File)
	Sat, Mar 21, 5:08 PM

	Unknown Object (File)
	Tue, Mar 17, 5:45 PM

	Unknown Object (File)
	Tue, Mar 17, 3:37 AM

View All 90 Files

Subscribers

imp

sef

Details

Reviewers

cem
jmg

Commits

rS362123: Fix AES-CCM requests with an AAD size smaller than a single block.

Summary

The amount to copy for the first block is the minimum of the size of the
AAD region or the remaining space in the first block.

Test Plan

cryptocheck -a aead -d aesni0 -z failed these requests with bad tags before and now the tags match

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31501
Build 29107: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jun 4 2020, 11:08 PM

jhb created this revision.

Harbormaster completed remote builds in B31501: Diff 72699.Jun 4 2020, 11:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 9:33 PM

Closed by commit rS362123: Fix AES-CCM requests with an AAD size smaller than a single block. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS362123: Fix AES-CCM requests with an AAD size smaller than a single block..

Herald added a reviewer: jmg. · View Herald TranscriptJun 12 2020, 9:33 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

sys/

crypto/

aesni/

aesni_ccm.c

2 lines

Diff 72699

View Options

sys/crypto/aesni/aesni_ccm.c

Fix AES-CCM requests with an AAD size smaller than a single block.ClosedPublicActions